Skip to content

feat(srtLoader): Implement SRT file loader#300

Merged
maxprilutskiy merged 11 commits intolingodotdev:mainfrom
partik03:loader-srt
Nov 10, 2024
Merged

feat(srtLoader): Implement SRT file loader#300
maxprilutskiy merged 11 commits intolingodotdev:mainfrom
partik03:loader-srt

Conversation

@partik03
Copy link
Copy Markdown
Contributor

@partik03 partik03 commented Nov 6, 2024

Should close #293

  • feat: Implement a new createSrtLoader() function in packages/cli/src/loaders/srt.ts to handle loading and saving SRT subtitle files
  • test: Add two unit tests in packages/cli/src/loaders/index.spec.ts to validate parsing of simple SRT files
  • docs: Update @replexica/spec to include the SRT file format specification
  • chore: Generate changelogs for both 'replexica' and '@replexica/cli' packages using pnpm new

Signed-off-by: Partik <partikbumrah13508@gmail.com>
Signed-off-by: Partik <partikbumrah13508@gmail.com>
Signed-off-by: Partik <partikbumrah13508@gmail.com>
Signed-off-by: Partik <partikbumrah13508@gmail.com>
@partik03
Copy link
Copy Markdown
Contributor Author

partik03 commented Nov 6, 2024

@maxprilutskiy kindly review this one

@maxprilutskiy
Copy link
Copy Markdown
Contributor

@partik03 looks good, please fix the build error (make sure the lockfile is in sync with package.json) and let's merge this one!

Great job!

Signed-off-by: Partik <partikbumrah13508@gmail.com>
Signed-off-by: Partik <partikbumrah13508@gmail.com>
Signed-off-by: Partik <partikbumrah13508@gmail.com>
@partik03
Copy link
Copy Markdown
Contributor Author

partik03 commented Nov 8, 2024

@maxprilutskiy done

Comment thread packages/cli/src/loaders/index.spec.ts Outdated
Signed-off-by: Partik <partikbumrah13508@gmail.com>
@partik03
Copy link
Copy Markdown
Contributor Author

@maxprilutskiy done now check once

@maxprilutskiy maxprilutskiy merged commit a6b22a3 into lingodotdev:main Nov 10, 2024
mainstar123 pushed a commit to mainstar123/lingo.dev that referenced this pull request Jul 7, 2025
* feat(cli): implemented srt loader

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: removed comments

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: changesets

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: changesets

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: fixed build errors

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: fixed build errors

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: fixed build errors

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* feat: changes to the srt loader

Signed-off-by: Partik <partikbumrah13508@gmail.com>

---------

Signed-off-by: Partik <partikbumrah13508@gmail.com>
Co-authored-by: Max Prilutskiy <5614659+maxprilutskiy@users.noreply.github.com>
17prateek12 pushed a commit to 17prateek12/lingo.dev that referenced this pull request Jan 23, 2026
* feat(cli): implemented srt loader

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: removed comments

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: changesets

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: changesets

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: fixed build errors

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: fixed build errors

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* chore: fixed build errors

Signed-off-by: Partik <partikbumrah13508@gmail.com>

* feat: changes to the srt loader

Signed-off-by: Partik <partikbumrah13508@gmail.com>

---------

Signed-off-by: Partik <partikbumrah13508@gmail.com>
Co-authored-by: Max Prilutskiy <5614659+maxprilutskiy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for SRT (SubRip Subtitle) file format

2 participants