Conversation
|
@DJMcNab The current version is ready for review.
|
DJMcNab
left a comment
There was a problem hiding this comment.
A few nits, all of which I'm happy to defer, but most of which it would probably be easier to do in this PR anyway.
Thank you so much for taking this on - this should make Kompari much more approachable.
There was a problem hiding this comment.
The other thing which might be worth changing is making the example test use the "base" Kompari for some/most of its logic.
Deferring that would be fine
|
The right solution for WASM I think is to make it so that the only package tested for wasm is the |
5b5ea7a to
6e14727
Compare
|
The last issue in CI is now: Do you know how to solve it in CI? |
|
Hmm. That error looks like rust-lang/cargo#14655 According to that PR, rust-lang/cargo#12861 should have made this impossible. The next option would be to manually change the version in the lockfile. |
If is continuation of #12. Very incomplete so far, I am now experimenting with different basic types. I am creating this PR for others to see what progress was made.