Skip to content

[WIP] Sf 6 compatibility - #598

Closed
magnetik wants to merge 1 commit into
liip:masterfrom
magnetik:sf6
Closed

[WIP] Sf 6 compatibility#598
magnetik wants to merge 1 commit into
liip:masterfrom
magnetik:sf6

Conversation

@magnetik

@magnetik magnetik commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

Trying to make this bundle compatible with Symfony 6

ref #597

@alexisLefebvre

Copy link
Copy Markdown
Collaborator

Thanks for the PR.

Tests with Symfony 6 should be green if you add Symfony 6 in .github/workflows/tests.yml.

The new config for security will work on Symfony 6 but not the older versions. If we can't find a way, we could load different config files in AppKernel, depending on the version of Symfony.

@xvilo

xvilo commented Mar 21, 2022

Copy link
Copy Markdown

Hi @magnetik, what is the status of this PR? Is it already finished, or do you need help>

@kl3sk

kl3sk commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

Hi @magnetik, does @alexisLefebvre solution solved your problems ?
Have this package available for SF6 will be great.

@gjuric

gjuric commented May 6, 2022

Copy link
Copy Markdown
Contributor

Can somebody with permissions rerun the tests so we can see what is failing? The current logs are not being shown since a lot of time has passed since the actions were run.

@alexisLefebvre

Copy link
Copy Markdown
Collaborator

I can't rerun these jobs.

@alexisLefebvre alexisLefebvre mentioned this pull request May 13, 2022
@alexisLefebvre

alexisLefebvre commented May 13, 2022

Copy link
Copy Markdown
Collaborator

In order to have the errors, I opened another PR from this one: #603

The current issue is that framework.session.storage_factory_id replaces framework.session.storage_id since Symfony 6.0 (deprecated in 5.3), we have to read 2 different config files.


One test of AllowedQueriesExceededException and some other things were broken on the main branch, I fixed these issues in another PR: #604 I'm not happy with the change of max_query_count from 1 to 0 in the internal tests but if it allow to have a version compatible with Symfony 6, it will be worth it.

@alexisLefebvre

alexisLefebvre commented May 18, 2022

Copy link
Copy Markdown
Collaborator

If you're interested in Symfony 6, please review #603

@alexisLefebvre

Copy link
Copy Markdown
Collaborator

Dear users, what methods from this bundle do you use? Which ones would you like to still use with Symfony 6?

@alexisLefebvre

Copy link
Copy Markdown
Collaborator

This was merged in #603, thanks @magnetik !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants