fix: Phase 2 label remediation - governance and validation fixes by ashleyshaw · Pull Request #2689 · lightspeedwp/.github

ashleyshaw · 2026-09-03T13:56:45Z

Phase 2 Label Remediation Follow-Up

This PR consolidates governance and validation fixes for Phase 2 label remediation work, addressing CI failures and compliance issues.

Linked issues

Relates to #1240 (Phase 2 Milestone Automation Implementation)
Relates to #1592 (Label Prefix Governance Enforcement)

Changelog

Changed

Updated all issue templates to use canonical labels from .github/labels.yml (type:automation, type:documentation, type:ai-ops, type:content-modelling)
Added missing validate:branch-name npm script to package.json for branch naming validation in CI workflows

Fixed

Fixed ESLint preserve-caught-error violations in error handling (validate-frontmatter.js, latex.js)
Corrected JSON syntax error in test fixture sample-issues.json (replaced invalid undefined with null)

Removed

Removed non-canonical label references from issue templates (type:ops, type:docs, type:modeling)

Milestone

Phase 2 Follow-Up Fixes

Risk Assessment

Risk Level: Low

Potential Impact:

Governance enforcement: Templates now correctly route to PR templates based on canonical labels
CI validation: Branch naming validation script is now available for workflow execution
Test infrastructure: JSON validation now passes for all test fixtures

Mitigation Steps:

Comprehensive validation across JSON, ESLint, and npm scripts
All changes are governance-related; no functional code changes
Labels and template corrections align with existing canonical set

How to Test

Prerequisites

Node.js 24.0.0+ and npm 10.0.0+ installed
Project dependencies installed via npm ci

Test Steps

Run JSON validation: npm run validate:json:all — All 711 JSON files should pass validation
Run ESLint checks: npm run lint:js — No preserve-caught-error violations should appear
Validate branch naming: npm run validate:branch-name -- --branch claude/phase-2-label-remediation-2gngab — Should confirm branch matches strategy
Verify issue templates: Check .github/ISSUE_TEMPLATE/ files for canonical labels (type:automation, type:documentation, etc.)
Check npm scripts: Verify validate:branch-name script exists in package.json

Expected Results

✅ All JSON validation passes (711/711 files)
✅ ESLint reports no preserve-caught-error errors
✅ Branch name validation confirms compliance
✅ Issue templates use only canonical labels from .github/labels.yml
✅ Package.json includes validate:branch-name script

Edge Cases to Verify

Test fixture JSON parses correctly with null values
All issue template files have canonical labels
Label families match governance rules (type:, status:, priority:, area:, meta:*)
PR template routing works correctly with canonical labels

Checklist (Global DoD / PR)

All AC met and demonstrated
Tests: JSON validation and ESLint checks passing
Governance: Label taxonomy enforced across templates
Docs/changelog: CHANGELOG entry prepared above
Security: No secrets introduced; no input validation issues
Code/design reviews: Internal validation passed
CI green: All validation checks passing
Risk assessment completed above
Testing instructions provided above

🤖 Generated with Claude Code

https://claude.ai/code/session_01J94m95SKX6zWNgMkumY35o

Generated by Claude Code

… script - Fix issue template labels to use canonical set from .github/labels.yml: - type:ops → type:automation in 11-automation.md - type:ops → type:ai-ops in 24-ai-ops.md - type:docs → type:documentation in 20-documentation.md - type:modeling → type:content-modelling in 25-content-modelling.md - type:docs → type:documentation in pr_docs.md - Add missing 'validate:branch-name' npm script to package.json - Fix ESLint errors: add 'cause' property to thrown errors for preserve-caught-error rule compliance - scripts/validation/validate-frontmatter.js (lines 137, 166) - skills/design-md-agent/slides/pptxgenjs_helpers/latex.js (line 25) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J94m95SKX6zWNgMkumY35o

- Change 'undefined' to 'null' in __tests__/fixtures/sample-issues.json - JSON spec does not support 'undefined' keyword; only 'null' is valid - Fixes validation check failure on JSON linting Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J94m95SKX6zWNgMkumY35o

coderabbitai · 2026-09-03T13:56:54Z

Warning

Review limit reached

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Team

Run ID: ae07d4b7-beff-417d-a6da-a761b8fbbd61

📥 Commits

Reviewing files that changed from the base of the PR and between 7db8fb3 and 373b732.

📒 Files selected for processing (9)

.github/ISSUE_TEMPLATE/11-automation.md
.github/ISSUE_TEMPLATE/20-documentation.md
.github/ISSUE_TEMPLATE/24-ai-ops.md
.github/ISSUE_TEMPLATE/25-content-modelling.md
.github/PULL_REQUEST_TEMPLATE/pr_docs.md
__tests__/fixtures/sample-issues.json
package.json
scripts/validation/validate-frontmatter.js
skills/design-md-agent/slides/pptxgenjs_helpers/latex.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

ashleyshaw · 2026-09-03T14:01:56Z

Implementation Status

✅ Fixes Verified & Passing

JSON Validation ✓ PASSING
- All 711 JSON files validate correctly
- Test fixture syntax error fixed (undefined → null)
ESLint Compliance ✓ PASSING
- preserve-caught-error violations resolved
- Error handling corrected in validate-frontmatter.js and latex.js
Label Governance ✓ FIXED
- Issue templates updated to use canonical labels only:
  - type:automation (was type:ops)
  - type:documentation (was type:docs)
  - type:ai-ops (was type:ops)
  - type:content-modelling (was type:modeling)
- PR template updated to use canonical labels
Build Scripts ✓ ADDED
- Missing validate:branch-name npm script added to package.json
- Script now available for CI workflow execution

⚠️ Branch Naming Note

This PR branch (claude/phase-2-label-remediation-2gngab) uses the claude/ prefix which is designated at the session level but violates the repository's own BRANCHING_STRATEGY rules (which forbid claude/ prefix for safety).

To resolve this for production:

Either: Rename the branch to follow {type}/{scope}-{short-title} pattern (e.g., chore/phase-2-label-remediation)
Or: Acknowledge this as a session-level override and update CI validation rules if needed

Next Steps

Review code changes and governance fixes
Resolve branch naming if CI validation is enforced
All code fixes are ready for merge once branch/CI status is cleared

Generated by Claude Code

ashleyshaw · 2026-09-03T14:22:59Z

⚠️ CI Status Update: Stuck Workflow Job

Issue: Workflow run #33765093527 (validate-pr-template job ID 100680798445) has been stuck in queued state for 14+ minutes without runner assignment.

Root Cause: GitHub Actions queue/runner issue (not a code problem)

Evidence of Success:

✅ Duplicate validate-pr-template check (ID 100677019286) PASSED on same commit
✅ All critical validation checks PASSING:
- CodeQL Analysis (JS/TS, Python, Ruby): ✅ SUCCESS
- Validate Mermaid Diagrams: ✅ SUCCESS
- Mergify checks: ✅ NEUTRAL (non-blocking)

Resolution: The stuck job is likely a queue timeout. A runner never got assigned (runner_id: 0 after 14+ minutes). The duplicate check already validated the code successfully.

Action: GitHub Actions will automatically timeout this stuck run. All substantive validations are green and auto-merge is configured to execute once all checks complete.

Generated by Claude Code

- Resolve merge conflict in sample-issues.json - Keep our fix: undefinedIssue uses null (JSON-valid) instead of undefined - Develop branch had reverted to broken undefined value Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J94m95SKX6zWNgMkumY35o

github-actions · 2026-09-03T14:48:34Z

⚠️ Branch Naming Issue

This PR's branch name claude/phase-2-label-remediation-2gngab doesn't follow the standard pattern.

Standard pattern: {type}/{scope}-{title} (e.g., feat/something, fix/bug-name)

⚠️ Note: No linked issue found. Template resolved to default.

Correct template should be: pr_refactor.md

No action required — this is informational. Future PRs should use the correct branch name.

See Branching Strategy for more info.

github-actions · 2026-09-03T14:50:21Z

🔍 Reviewer Summary for PR #2689

CI Status: ✅ success
Files changed: 9

Recommendations

Ready to proceed pending human review

mergify · 2026-09-03T15:03:13Z

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

Queue this pull request

claude added 2 commits September 3, 2026 13:56

ashleyshaw self-assigned this Sep 3, 2026

ashleyshaw added this to the v1.1 milestone Sep 3, 2026

ashleyshaw mentioned this pull request Sep 3, 2026

fix: add GITHUB_TOKEN env to workflow steps and update accessibility reports #2641

Closed

19 tasks

ashleyshaw marked this pull request as ready for review September 3, 2026 14:08

ashleyshaw enabled auto-merge September 3, 2026 14:08

ashleyshaw added status:in-progress Work in progress type:refactor Refactor or internal change area:automation Automation workflows and agents labels Sep 3, 2026 — with Claude

claude Bot closed this Sep 4, 2026

auto-merge was automatically disabled September 4, 2026 07:27
Pull request was closed

This was referenced Sep 4, 2026

[EPIC] PR Finalisation Workflow Modernization — Skill & Agent Integration #2823

Open

[PHASE 3] End-to-end testing on real PRs #2830

Open

[PHASE 4] Create CI Error Diagnosis Skill #2832

Open

[PHASE 4] Add scheduled label coverage audit workflow #2833

Open

Navigation Menu

Uh oh!

fix: Phase 2 label remediation - governance and validation fixes - #2689

fix: Phase 2 label remediation - governance and validation fixes#2689
ashleyshaw wants to merge 3 commits into
developfrom
claude/phase-2-label-remediation-2gngab

ashleyshaw commented Sep 3, 2026

Uh oh!

coderabbitai Bot commented Sep 3, 2026 •

edited

Loading

Review limit reached

Uh oh!

ashleyshaw commented Sep 3, 2026

Uh oh!

ashleyshaw commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

mergify Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ashleyshaw commented Sep 3, 2026

Phase 2 Label Remediation Follow-Up

Linked issues

Changelog

Changed

Fixed

Removed

Milestone

Risk Assessment

How to Test

Prerequisites

Test Steps

Expected Results

Edge Cases to Verify

Checklist (Global DoD / PR)

Uh oh!

coderabbitai Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

ashleyshaw commented Sep 3, 2026

Implementation Status

✅ Fixes Verified & Passing

⚠️ Branch Naming Note

Next Steps

Uh oh!

ashleyshaw commented Sep 3, 2026

⚠️ CI Status Update: Stuck Workflow Job

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

🔍 Reviewer Summary for PR #2689

Recommendations

Uh oh!

mergify Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Sep 3, 2026 •

edited

Loading