Adds more tests for the File classes to ensure behaviour ahead of refactor - #571
Merged
Merged
Conversation
rtibbles
force-pushed
the
more_files_tests
branch
from
February 17, 2025 18:52
f41b7da to
4cda946
Compare
marcellamaki
approved these changes
Feb 17, 2025
marcellamaki
left a comment
marcellamaki
left a comment
Member
There was a problem hiding this comment.
since this is only adding tests, and the code is very readable, i will approve. we can adjust (or make further additions) to tests as needed in the future in the refactor if different behavior is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert Trueand were doing nothing of any useReferences
In support of #558
Reviewer guidance
Do all tests make sense? Do they pass on all platforms for all Python versions?