Added encoding on reading json file - #415
Merged
rtibbles merged 1 commit intoMay 2, 2023
Merged
Conversation
rtibbles
force-pushed
the
fix-encoding-bug-jsontree
branch
from
May 2, 2023 22:31
9b5c7c6 to
5c31235
Compare
rtibbles
approved these changes
May 2, 2023
rtibbles
left a comment
rtibbles
left a comment
Member
There was a problem hiding this comment.
Encodings matter! This looks good, merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have encoding on write tree to json, but we didn't have encoding utf8 on read_tree_from_json