Save metadata to csv - #290
Conversation
| # if len(structure_list) < 1: | ||
| # structure_list = [current_level] | ||
| # else: | ||
| structure_list = list(structure_list) |
There was a problem hiding this comment.
This line can be removed.
There was a problem hiding this comment.
I tried printing the structure list out with this line removed and it was printing out incorrectly. Seems that it was still passing in by reference
There was a problem hiding this comment.
Ah, thanks, so it looks like what I read about list() as a function arg creating a new list each time was false. So let's make sure that any list or dict objects with default values default to None and that we set it when it is None the top of the function, like so:
if structure_list is None:
structure_list = []
There was a problem hiding this comment.
updated list to be named as branch_structure_list for now as it is keeping track of the structure of each branch. Can name it to something different in the future
kollivier
left a comment
kollivier
left a comment
There was a problem hiding this comment.
Thanks for all your hard work on this! LGTM! :)
2 participants
No description provided.