Skip to content

Replace UIScreen.main to get display scale on iOS 13.0 and later #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucdion merged 4 commits into from
Nov 3, 2023
Merged

Replace UIScreen.main to get display scale on iOS 13.0 and later #275

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21c44db
Use UIApplication instead of UIScreen.main on iOS 13.0 and later
hyun99999 Oct 18, 2023
1703b4d
Add control flow's condition
hyun99999 Oct 18, 2023
b2ff6d5
Fix .zero to 1.0 ensure minimal operation through the scale factor.
hyun99999 Oct 18, 2023
d103ba2
Use UITraitCollection to access display scale
hyun99999 Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/Impl/Coordinates.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,12 @@ final class Coordinates<PinView: Layoutable> {

private func getDisplayScale() -> CGFloat {
#if os(iOS) || os(tvOS)
if #available(iOS 13.0, tvOS 13.0, *) {
let windowScene = UIApplication.shared.connectedScenes.first as? UIWindowScene
return windowScene?.screen.scale ?? 1.0
} else {
return UIScreen.main.scale
}
#elseif os(OSX)
#if swift(>=4.1)
return NSScreen.main?.backingScaleFactor ?? 2.0
Expand Down