Skip to content

test: use sqlite3 session in test_comment_models#38767

Merged
41tair merged 1 commit into
langgenius:mainfrom
asukaminato0721:sqlite3-models-test_comment_models
Jul 13, 2026
Merged

test: use sqlite3 session in test_comment_models#38767
41tair merged 1 commit into
langgenius:mainfrom
asukaminato0721:sqlite3-models-test_comment_models

Conversation

@asukaminato0721

Copy link
Copy Markdown
Contributor

Replace mocked db.session.get calls and fake account rows with a real in-memory SQLite session and persisted Account, WorkflowComment, reply, and mention models. Verify account lookup, participants, counts, missing accounts, and cache behavior through database state. Part of #32454.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 52.85% 52.86% +0.01%
Strict coverage 52.36% 52.37% +0.01%
Typed symbols 32,803 32,813 +10
Untyped symbols 29,539 29,539 0
Modules 2988 2988 0

@asukaminato0721 asukaminato0721 requested a review from 41tair July 13, 2026 05:46
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 13, 2026
@41tair 41tair added this pull request to the merge queue Jul 13, 2026
Merged via the queue into langgenius:main with commit 7909c0c Jul 13, 2026
31 checks passed
@asukaminato0721 asukaminato0721 deleted the sqlite3-models-test_comment_models branch July 13, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants