Skip to content

docs: correct stable row ID migration and storage - #8852

Open
lance-gatefixer[bot] wants to merge 103 commits into
mainfrom
gatekeeper/fix-8851-1
Open

docs: correct stable row ID migration and storage#8852
lance-gatefixer[bot] wants to merge 103 commits into
mainfrom
gatekeeper/fix-8851-1

Conversation

@lance-gatefixer

Copy link
Copy Markdown
Contributor

Summary

  • document how existing datasets migrate to stable row IDs and the index/concurrency constraints
  • clarify that current writers always emit row ID and version sequences inline
  • mark external version-sequence fields as unsupported and reserved while retaining the supported external row-ID read contract

Root cause

The format documentation and protobuf comments still described pre-implementation plans: they said existing datasets could not migrate and presented a 200 KB inline/external threshold as active writer behavior. Migration has since shipped, but writers still emit every sequence inline and readers cannot load external version sequences.

Validation

  • protoc --proto_path=../protos --descriptor_set_out=/dev/null ../protos/table.proto
  • uv run mkdocs build (completed with pre-existing missing-link warnings outside this change)
  • git diff --check

Fixes #8851

@github-actions github-actions Bot added A-format On-disk format: protos and format spec docs format-change A change to the format spec, which requires a vote. Remove if minor (e.g. fixing typo). documentation Improvements or additions to documentation labels Aug 28, 2026
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Important

Format specification vote

This PR modifies the Lance format specification, so it requires 3 binding +1 votes from PMC members (excluding the proposer) and a minimum 72-hour voting period, weekends excluded, before it can merge. Vote by approving this PR (+1) or requesting changes (−1, a veto). See the voting process.

Status: ❌ Blocked — 0 of 3 required approvals

Approvals (this commit) none (0/3)
Vetoes none
Voting period elapsed — ended Wed 2026-09-02 19:20 UTC (12:20 PDT)

Updated automatically by the format-spec vote gate, which re-checks every 15 minutes — just voted? Re-check now (press Run workflow; leave the input blank to re-check every open format PR). A PMC member may apply the format-waived label to waive the vote for a trivial edit (typo, wording, formatting).

lance-gatekeeper[bot]

This comment was marked as outdated.

@lance-gatekeeper lance-gatekeeper Bot added the K-changes Latest Gatekeeper recommendation requests changes. label Aug 28, 2026
@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head cannot pass format-spec-vote until the required PMC approval process is satisfied.

Remote head 6682e7ddccc27d8a3fa28c9cdd297dfd906496de contains the current main tip 5b14b344e8c9757036cc7cf0b2e134ee233560b1; the live format-spec-vote status reports 0/3 PMC approvals on this commit, while Actions run 33204888739 and its evaluator job completed successfully. I fetched both branches, verified ancestry, inspected the current-head status and logs, and found no terminal build or test failure or attributable code defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatekeeper lance-gatekeeper Bot removed the K-changes Latest Gatekeeper recommendation requests changes. label Aug 28, 2026
lance-gatekeeper[bot]

This comment was marked as outdated.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Aug 28, 2026
@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head cannot pass format-spec-vote until the required PMC approval process is satisfied.

Remote head 6682e7ddccc27d8a3fa28c9cdd297dfd906496de contains the current main tip 5b14b344e8c9757036cc7cf0b2e134ee233560b1; the live format-spec-vote status reports 0/3 PMC approvals on this commit, while current-head Actions run 33205470285 and its evaluator job completed successfully. I fetched both branches, verified ancestry, inspected all current-head checks and the evaluator logs, and found no terminal build or test failure or attributable code defect to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head is held by an unrelated Windows runner failure and the required format-spec approval gate.

Remote head 6682e7ddccc27d8a3fa28c9cdd297dfd906496de contains the current main tip 5b14b344e8c9757036cc7cf0b2e134ee233560b1. Python windows job 98963312295 failed only test_torch_index_with_nans[Legacy] because PyTorch Inductor received PermissionError reopening a generated runner-temp file; the same test passed on Windows for the exact base in job 98918373866, and this branch changes only Markdown and protobuf comments. Separately, format-spec-vote reports 0/3 PMC approvals on this commit. I fetched both branches, verified ancestry, compared the current-head and exact-base logs, and found no attributable code defect to repair. The smallest next actions are to rerun the failed Windows job on a clean hosted runner and obtain the required three binding +1 PMC approvals after the voting period; practical alternatives are rerunning the full Python workflow and, if this documentation correction qualifies as trivial, having a PMC member apply format-waived.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head remains held by an unrelated Windows hosted-runner failure and the required format-spec approval gate.

Remote head 6682e7ddccc27d8a3fa28c9cdd297dfd906496de contains the current main tip 5b14b344e8c9757036cc7cf0b2e134ee233560b1. Python windows job 98963312295 failed only test_torch_index_with_nans[Legacy] because PyTorch Inductor received PermissionError reopening a generated runner-temp file; exact-base Windows job 98918373866 passed that test and all 1,364 tests, while this branch changes only Markdown and protobuf comments. Separately, format-spec-vote reports 0/3 PMC approvals on this commit, and evaluator run 33209947118 completed successfully. I fetched both branches, verified ancestry, compared the current-head and exact-base logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next actions are to rerun the failed Windows job on a clean hosted runner and obtain three binding +1 PMC approvals after the voting period; practical alternatives are rerunning the full Python workflow and, if this documentation correction qualifies as trivial, having a PMC member apply format-waived.

@lance-gatekeeper lance-gatekeeper Bot removed the K-approved Latest Gatekeeper recommendation permits acceptance. label Aug 28, 2026
lance-gatekeeper[bot]

This comment was marked as outdated.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Aug 28, 2026
@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes.

Remote head 01197a5e6e91acb18b0bf5bfd8f7d33538c44a55 contains the current main tip 085354e6ac9f6178aa15fcb4bb1ab410c82bd203. The live format-spec-vote status targets Actions run 33216656108 and reports 0/3 PMC approvals on this commit; its evaluator job 99001687932 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes.

Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33217104161 and reports 0/3 PMC approvals on this commit; its evaluator job 99003082863 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes.

Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33218990261 and reports 0/3 PMC approvals on this commit; its evaluator job 99008845859 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes.

Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33219934264 and reports 0/3 PMC approvals on this commit; its evaluator job 99011652281 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes.

Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33220685156 and reports 0/3 PMC approvals on this commit; its evaluator job 99013887195 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes.

Remote head 01197a5e6e91acb18b0bf5bfd8f7d33538c44a55 contains the current main tip 085354e6ac9f6178aa15fcb4bb1ab410c82bd203. The live format-spec-vote status targets Actions run 33221480344 and reports 0/3 PMC approvals on this commit; its evaluator job 99016231702 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes.

Remote head 01197a5e6e91acb18b0bf5bfd8f7d33538c44a55 contains the current main tip 085354e6ac9f6178aa15fcb4bb1ab410c82bd203. The live format-spec-vote status targets Actions run 33222441276 and reports 0/3 PMC approvals on this commit; its evaluator job 99019148730 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatekeeper lance-gatekeeper Bot removed the K-approved Latest Gatekeeper recommendation permits acceptance. label Aug 29, 2026
lance-gatekeeper[bot]

This comment was marked as outdated.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Aug 29, 2026
@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

Remote head 0c60be6396a7e00de721090ed3ce875831e883ed contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The status targets Actions run 34171130274; evaluator job 101891483055 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit, while all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and branch identity, inspected the live Issue, PR, reviews, comments, checks, status, and evaluator logs, recompiled the protobuf descriptor, rebuilt the documentation, ran diff checks, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

Remote head 0c60be6396a7e00de721090ed3ce875831e883ed contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The status targets Actions run 34172173677; evaluator job 101894434553 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit, while all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and branch identity, inspected the live Issue, PR, reviews, comments, checks, status, and evaluator logs, recompiled the protobuf descriptor, rebuilt the documentation, ran diff checks, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

Remote head 0c60be6396a7e00de721090ed3ce875831e883ed contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The status targets Actions run 34175061705; evaluator job 101902716542 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit, while all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and branch identity, inspected the live Issue, PR, reviews, comments, checks, status, and evaluator logs, recompiled the protobuf descriptor, rebuilt the documentation, ran diff checks, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

Remote head 0c60be6396a7e00de721090ed3ce875831e883ed contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The status targets Actions run 34177753162; evaluator job 101910447391 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit, while all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and branch identity, inspected the live Issue, PR, reviews, comments, checks, status, and evaluator logs, recompiled the protobuf descriptor, rebuilt the documentation, ran diff checks, and pushed the assigned branch normally; it was already up to date, with no attributable repository defect to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

The verified remote head contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The failing status targets Actions run 34178703087, whose evaluator job 101913166067 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit; all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and PR identity, inspected the live checks and evaluator logs, reran protobuf and documentation validation plus git diff --check, and pushed the assigned branch normally; no attributable repository defect remains to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

The verified remote head contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The failing status targets Actions run 34178703087, whose evaluator job 101913166067 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit; all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and PR identity, inspected the live checks and evaluator logs, reran protobuf and documentation validation plus git diff --check, and pushed the assigned branch normally; no attributable repository defect remains to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

The verified remote head contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The failing status targets Actions run 34180346446, whose evaluator job 101917988882 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit; all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and PR identity, inspected the live checks and evaluator logs, reran protobuf and documentation validation plus git diff --check, and pushed the assigned branch normally; no attributable repository defect remains to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

The verified remote head contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The failing status targets Actions run 34182132169, whose evaluator job 101923180418 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit; all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and PR identity, inspected the live checks and evaluator logs, reran protobuf and documentation validation plus git diff --check, and pushed the assigned branch normally; no attributable repository defect remains to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

The remote head contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. All 33 current-head CheckRuns pass, while the live failing format-spec-vote context targets Actions run 34182132169; evaluator job 101923180418 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit. I fetched both branches, verified ancestry and exact identities, reviewed the current PR conversations, checks, and evaluator logs, reran protobuf and documentation validation plus whitespace checks, and confirmed the normal branch push is up to date; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

The remote head contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. All 33 current-head CheckRuns pass, while the live failing format-spec-vote context targets Actions run 34184264924; evaluator job 101929337215 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit. I fetched both branches, verified ancestry and exact identities, reviewed current PR conversations, reviews, checks, and evaluator logs, reran protobuf and documentation validation plus whitespace checks, and confirmed the normal branch push is up to date; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

The remote head contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. All 33 current-head CheckRuns pass, while the live failing format-spec-vote context targets Actions run 34184750191; evaluator job 101930725668 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit. I fetched both branches, verified ancestry and exact identities, reviewed current PR conversations, reviews, checks, and evaluator logs, reran protobuf and documentation validation plus whitespace checks, and confirmed the normal branch push is up to date; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

Remote head 0c60be6396a7e00de721090ed3ce875831e883ed contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The failing status targets Actions run 34185565561; evaluator job 101933099695 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit, while all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and PR identity, inspected the live Issue, reviews, threads, comments, checks, status, and evaluator logs, recompiled the protobuf descriptor, rebuilt the documentation, ran diff checks, and pushed the assigned branch normally; it was already up to date, with no attributable repository failure to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

Remote head 0c60be6396a7e00de721090ed3ce875831e883ed contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The failing status targets Actions run 34187692768; evaluator job 101939237824 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit, while all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and PR identity, inspected the live Issue, reviews, threads, comments, checks, status, and evaluator logs, recompiled the protobuf descriptor, rebuilt the documentation, ran diff checks, and pushed the assigned branch normally; it was already up to date, with no attributable repository failure to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

Remote head 0c60be6396a7e00de721090ed3ce875831e883ed contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The failing status targets Actions run 34188236817; evaluator job 101940795958 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit, while all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and PR identity, inspected the live Issue, reviews, threads, comments, checks, status, and evaluator logs, recompiled the protobuf descriptor, rebuilt the documentation, ran diff checks, and pushed the assigned branch normally; it was already up to date, with no attributable repository failure to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 0c60be6396a7e00de721090ed3ce875831e883ed cannot pass the required format-spec-vote because the current commit status reports 0/3 PMC approvals on this commit.

Remote head 0c60be6396a7e00de721090ed3ce875831e883ed contains the current main tip bea84ccb43845db19c948b28badaf3de9d51c25d. The failing status targets Actions run 34189112477; evaluator job 101943330865 completed successfully and logged PR #8852: 0/3 PMC approvals on this commit, while all 33 current-head CheckRuns pass. I fetched both branches, verified ancestry and PR identity, inspected the live Issue, reviews, threads, comments, checks, status, and evaluator logs, recompiled the protobuf descriptor, rebuilt the documentation, ran diff checks, and pushed the assigned branch normally; it was already up to date, with no attributable repository failure to repair.

The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial.

lance-gatekeeper[bot]

This comment was marked as outdated.

lance-gatekeeper[bot]

This comment was marked as outdated.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf remains blocked by a flaky Rust windows-build failure and the required format-spec-vote approval gate.

Remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf contains the current main tip bba83906027be60b48741443d6a4e2007564d747. Rust Actions run 34196207915 job 101964377633 failed only test_optimize_vector_index_drops_stale_rows_on_merge::case_1_ivf_flat::enable_stable_row_ids_1_false when Windows returned Access is denied (os error 5) while persisting a runner-temp shuffle_data.lance; exact-base Windows job 101959516118 passed, the branch changes only Markdown and protobuf files, and all other current-head jobs pass. The live format-spec-vote status reports 0/3 PMC approvals on this commit. I fetched both branches, verified ancestry and PR identity, inspected the current checks and logs, recompiled the protobuf descriptor, rebuilt the documentation, ran git diff --check, attempted the failed-job rerun, and verified the normal branch push is up to date; no attributable repository defect remains to repair.

The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply format-waived.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf remains blocked by a flaky Rust windows-build failure and the required format-spec-vote approval gate.

Remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf contains the current main tip bba83906027be60b48741443d6a4e2007564d747. Rust Actions run 34196207915 job 101964377633 failed only test_optimize_vector_index_drops_stale_rows_on_merge::case_1_ivf_flat::enable_stable_row_ids_1_false when Windows returned Access is denied (os error 5) while persisting a runner-temp shuffle_data.lance; exact-base Windows job 101959516118 passed, the branch changes only Markdown and protobuf files, and all other current-head jobs pass. The latest vote evaluator, run 34199288462 job 101974125375, completed successfully and reports PR #8852: 0/3 PMC approvals on this commit. I fetched both branches, verified ancestry and PR identity, inspected the current checks and logs, recompiled the protobuf descriptor, rebuilt the documentation, ran git diff --check, and verified the normal branch push is up to date; no attributable repository defect remains to repair.

The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply format-waived.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf remains blocked by a flaky Rust windows-build failure and the required format-spec-vote approval gate.

Remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf contains the current main tip bba83906027be60b48741443d6a4e2007564d747. Rust Actions run 34196207915 job 101964377633 failed only test_optimize_vector_index_drops_stale_rows_on_merge::case_1_ivf_flat::enable_stable_row_ids_1_false when Windows returned Access is denied (os error 5) while persisting a runner-temp shuffle_data.lance; exact-base Windows job 101959516118 passed, the branch changes only Markdown and protobuf files, and all other current-head jobs pass. The latest vote evaluator, run 34200126895 job 101976768874, completed successfully and reports PR #8852: 0/3 PMC approvals on this commit. I fetched both branches, verified ancestry and PR identity, inspected the current checks and logs, recompiled the protobuf descriptor, rebuilt the documentation, ran git diff --check, and verified the normal branch push is up to date; no attributable repository defect remains to repair.

The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply format-waived.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf remains blocked by a non-attributable Rust Windows runner failure and the required format-spec-vote approval gate.

Remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf contains the current main tip bba83906027be60b48741443d6a4e2007564d747. Rust Actions run 34196207915, job 101964377633, failed only test_optimize_vector_index_drops_stale_rows_on_merge::case_1_ivf_flat::enable_stable_row_ids_1_false when Windows returned Access is denied (os error 5) while persisting a runner-temp shuffle_data.lance; exact-base Windows job 101959516118 passed, the branch changes only Markdown and protobuf files, and all other current-head CheckRuns pass. The latest format-spec-vote evaluator, run 34202423514, completed successfully but reports PR #8852: 0/3 PMC approvals on this commit.

I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected the current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply format-waived.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf remains blocked by a non-attributable Rust Windows runner failure and the required format-spec-vote approval gate.

Remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf contains the current main tip bba83906027be60b48741443d6a4e2007564d747. Rust Actions run 34196207915, job 101964377633, failed only test_optimize_vector_index_drops_stale_rows_on_merge::case_1_ivf_flat::enable_stable_row_ids_1_false when Windows returned Access is denied (os error 5) while persisting a runner-temp shuffle_data.lance; exact-base Windows job 101959516118 passed, the branch changes only Markdown and protobuf files, and all other current-head CheckRuns pass. The live format-spec-vote context targets run 34202423514, whose evaluator completed successfully but reports PR #8852: 0/3 PMC approvals on this commit.

I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected the current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply format-waived.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf remains blocked by a non-attributable Rust Windows runner failure and the required format-spec-vote approval gate.

Remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf contains the current main tip bba83906027be60b48741443d6a4e2007564d747. Rust Actions run 34196207915, job 101964377633, failed only test_optimize_vector_index_drops_stale_rows_on_merge::case_1_ivf_flat::enable_stable_row_ids_1_false when Windows returned Access is denied (os error 5) while persisting a runner-temp shuffle_data.lance; exact-base Windows job 101959516118 passed, the branch changes only Markdown and protobuf files, and all other current-head CheckRuns pass. The live format-spec-vote context targets run 34204953916, whose evaluator completed successfully but reports PR #8852: 0/3 PMC approvals on this commit.

I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected the current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply format-waived.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf remains blocked by a non-attributable Rust Windows runner failure and the required format-spec-vote approval gate.

Remote head 8f8a423c4176d7596803ea9564e1b9d161b030bf contains the current main tip bba83906027be60b48741443d6a4e2007564d747. Rust Actions run 34196207915, job 101964377633, failed only test_optimize_vector_index_drops_stale_rows_on_merge::case_1_ivf_flat::enable_stable_row_ids_1_false when Windows returned Access is denied (os error 5) while persisting a runner-temp shuffle_data.lance; exact-base Windows job 101959516118 passed, the branch changes only Markdown and protobuf files, and all other current-head CheckRuns pass. The live format-spec-vote context targets run 34207787748, whose evaluator completed successfully but reports PR #8852: 0/3 PMC approvals on this commit.

I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected the current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply format-waived.

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: approve.

The pull-request patch remains unchanged. The new base fix repairs in-memory HNSW graph reachability after parallel construction and before the existing serialization path. It does not change index commit/rebase behavior, fragment metadata, stable-row-ID migration, or row/version-sequence storage, so the corrected format guidance remains accurate.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head cdd602de484f1bf5fbe1a130261c913f47bf6241 remains blocked by two non-attributable test failures and the required format-spec-vote approval gate.

Remote head cdd602de484f1bf5fbe1a130261c913f47bf6241 contains the current main tip 44489bd11e5865e4190676fed1deb4fd9f78732b. Rust run 34209773288, macOS job 102007733404, failed two MemWAL vector-search tests with final offset 3 does not match shuffle data row count 1, while exact-base macOS job 102007142263 passed. Python run 34209773283, Windows job 102007733098, failed only test_index_cast_centroids on a TorchInductor runner-temp PermissionError, while exact-base Windows job 102007142282 passed. This branch changes only Markdown and protobuf comments. Separately, the live format-spec-vote status targets run 34210962176; evaluator job 102011585457 completed successfully but reports PR #8852: 0/3 PMC approvals on this commit.

I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are to rerun the failed macOS and Windows jobs on clean runners and obtain three binding +1 PMC approvals. Practical alternatives are to rerun the full Rust and Python workflows and, if this documentation correction qualifies as trivial, have a PMC member apply format-waived.

@lance-gatefixer

Copy link
Copy Markdown
Contributor Author

Blocked: PR #8852 at remote head cdd602de484f1bf5fbe1a130261c913f47bf6241 remains blocked by two non-attributable test failures and the required format-spec-vote approval gate.

Remote head cdd602de484f1bf5fbe1a130261c913f47bf6241 contains the current main tip 44489bd11e5865e4190676fed1deb4fd9f78732b. Rust run 34209773288, macOS job 102007733404, failed two MemWAL vector-search tests with final offset 3 does not match shuffle data row count 1, while exact-base macOS job 102007142263 passed. Python run 34209773283, Windows job 102007733098, failed only test_index_cast_centroids on a TorchInductor runner-temp PermissionError, while exact-base Windows job 102007142282 passed. This branch changes only Markdown and protobuf comments. Separately, the live format-spec-vote status targets run 34211841852; evaluator job 102014415548 completed successfully but reports PR #8852: 0/3 PMC approvals on this commit.

I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are to rerun the failed macOS and Windows jobs on clean runners and obtain three binding +1 PMC approvals. Practical alternatives are to rerun the full Rust and Python workflows and, if this documentation correction qualifies as trivial, have a PMC member apply format-waived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-format On-disk format: protos and format spec docs documentation Improvements or additions to documentation format-change A change to the format spec, which requires a vote. Remove if minor (e.g. fixing typo). K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: stable row id spec describes migration and inline/external storage inaccurately

0 participants