docs: correct stable row ID migration and storage - #8852
docs: correct stable row ID migration and storage#8852lance-gatefixer[bot] wants to merge 103 commits into
Conversation
|
Important Format specification voteThis PR modifies the Lance format specification, so it requires 3 binding +1 votes from PMC members (excluding the proposer) and a minimum 72-hour voting period, weekends excluded, before it can merge. Vote by approving this PR (+1) or requesting changes (−1, a veto). See the voting process. Status: ❌ Blocked — 0 of 3 required approvals
Updated automatically by the format-spec vote gate, which re-checks every 15 minutes — just voted? Re-check now (press Run workflow; leave the input blank to re-check every open format PR). A PMC member may apply the |
|
Blocked: the current head cannot pass Remote head |
|
Blocked: the current head cannot pass Remote head |
|
Blocked: the current head is held by an unrelated Windows runner failure and the required format-spec approval gate. Remote head |
|
Blocked: the current head remains held by an unrelated Windows hosted-runner failure and the required format-spec approval gate. Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33217104161 and reports 0/3 PMC approvals on this commit; its evaluator job 99003082863 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33218990261 and reports 0/3 PMC approvals on this commit; its evaluator job 99008845859 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33219934264 and reports 0/3 PMC approvals on this commit; its evaluator job 99011652281 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33220685156 and reports 0/3 PMC approvals on this commit; its evaluator job 99013887195 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head The verified remote head contains the current The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head The verified remote head contains the current The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head The verified remote head contains the current The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head The verified remote head contains the current The smallest next action is for three eligible PMC members to provide binding +1 approvals; alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head The remote head contains the current |
|
Blocked: PR #8852 at remote head The remote head contains the current |
|
Blocked: PR #8852 at remote head The remote head contains the current |
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and rerun the format vote gate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply |
|
Blocked: PR #8852 at remote head Remote head The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply |
|
Blocked: PR #8852 at remote head Remote head I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected the current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply |
|
Blocked: PR #8852 at remote head Remote head I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected the current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply |
|
Blocked: PR #8852 at remote head Remote head I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected the current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply |
|
Blocked: PR #8852 at remote head Remote head I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected the current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are for a maintainer with Actions permission to rerun the failed Rust job on a clean Windows runner and for three eligible PMC members to provide binding +1 approvals. Practical alternatives are rerunning the full Rust workflow and, if this documentation correction qualifies as trivial, having a PMC member apply |
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The pull-request patch remains unchanged. The new base fix repairs in-memory HNSW graph reachability after parallel construction and before the existing serialization path. It does not change index commit/rebase behavior, fragment metadata, stable-row-ID migration, or row/version-sequence storage, so the corrected format guidance remains accurate.
|
Blocked: PR #8852 at remote head Remote head I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are to rerun the failed macOS and Windows jobs on clean runners and obtain three binding +1 PMC approvals. Practical alternatives are to rerun the full Rust and Python workflows and, if this documentation correction qualifies as trivial, have a PMC member apply |
|
Blocked: PR #8852 at remote head Remote head I fetched both branches, verified base ancestry and the exact Ready-PR identity, inspected current-head and exact-base checks and logs, compiled and linted the protobuf, rebuilt the documentation, ran the diff check, and pushed normally; the branch is up to date and no attributable repository defect remains to repair. The smallest next actions are to rerun the failed macOS and Windows jobs on clean runners and obtain three binding +1 PMC approvals. Practical alternatives are to rerun the full Rust and Python workflows and, if this documentation correction qualifies as trivial, have a PMC member apply |
Summary
Root cause
The format documentation and protobuf comments still described pre-implementation plans: they said existing datasets could not migrate and presented a 200 KB inline/external threshold as active writer behavior. Migration has since shipped, but writers still emit every sequence inline and readers cannot load external version sequences.
Validation
protoc --proto_path=../protos --descriptor_set_out=/dev/null ../protos/table.protouv run mkdocs build(completed with pre-existing missing-link warnings outside this change)git diff --checkFixes #8851