Skip to content

Delete vendor directory - #87

Merged
k8s-ci-robot merged 4 commits into
kubernetes-sigs:masterfrom
jngo2:master
Dec 5, 2022
Merged

Delete vendor directory#87
k8s-ci-robot merged 4 commits into
kubernetes-sigs:masterfrom
jngo2:master

Conversation

@jngo2

@jngo2 jngo2 commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

Removing the vendor directory as requested.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2022
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @jngo2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 30, 2022
@micahhausler

Copy link
Copy Markdown
Member

/retest

@micahhausler

Copy link
Copy Markdown
Member

@jngo2 I think you'll have to fix some of the test expectations about vendored code

@jngo2

jngo2 commented Oct 5, 2022

Copy link
Copy Markdown
Contributor Author

/retest

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@jngo2: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@micahhausler

Copy link
Copy Markdown
Member

/retest

1 similar comment
@xdu31

xdu31 commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

/retest

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@xdu31: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xdu31

xdu31 commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

@micahhausler

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2022
@micahhausler

Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2022
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jngo2, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@k8s-ci-robot
k8s-ci-robot merged commit a765ea8 into kubernetes-sigs:master Dec 5, 2022
ngraef added a commit to ngraef/aws-encryption-provider that referenced this pull request Dec 6, 2022
ngraef added a commit to ngraef/aws-encryption-provider that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants