Add EVENT.BFCACHE zoid events (re-apply #478) - #485
Merged
Conversation
nikrom17
force-pushed
the
revert-480-reland-478
branch
from
July 6, 2026 20:14
92b6a71 to
1381fd2
Compare
nikrom17
changed the title
dtjones404
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-applies #478 (
EVENT.BFCACHE_CACHE/EVENT.BFCACHE_RESTORElifecycle events), which was reverted by #480 on 2026-04-03.This is a straight
git revertof the revert commit (49047ed) — verified line-for-line identical to the original #478 diff, no code changes. #478 and #480 don't touch any files modified by #484 (global key strategy fix), so there's no merge conflict or interaction between them.Why the original revert happened
The 2026-04-03 revert was not a defect in this diff itself. It was caused by zoid's version-baked
__GLOBAL_KEY__breakingpassByReferenceserialization whenever parent and child windows loaded different zoid versions on the same domain during rollout (~16,000 excessSDK_INTEGRATION_LOADING_ERRORs). That root cause has since been fixed in #484 (fix: change global key strategy, merged and published as part of10.5.3), which shares a major-version-keyed global across all10.xreleases instead of keying on the full version string. Phase 2 of that fix will follow once the bfcache work (this PR, #479, and downstream PCC/SCNW work) is complete.Test plan
Used Custom BFcache test harness
DTPPCPSDK-5691