Skip to content

support compiling set-ns and set-labels to wasm#898

Merged
mengqiy merged 1 commit intokptdev:masterfrom
mengqiy:setnswasm
Aug 18, 2022
Merged

support compiling set-ns and set-labels to wasm#898
mengqiy merged 1 commit intokptdev:masterfrom
mengqiy:setnswasm

Conversation

@mengqiy
Copy link
Copy Markdown

@mengqiy mengqiy commented Aug 5, 2022

How to compile:

$ cd functions/go/set-namespace
$ GOOS=js GOARCH=wasm go build -o set-namespace.wasm 

@mengqiy mengqiy changed the title support compile set-ns to wasm support compiling set-ns to wasm Aug 5, 2022
@yuwenma
Copy link
Copy Markdown
Contributor

yuwenma commented Aug 5, 2022

So cool! Is this for experimental purpose or you literally want set-namespace to be the pilot function for WASM? If it's the former, quick approval on my side. Just FYI, the latest set-namespace code is not released. It contains major changes like supporting upstream identifier. Just to mention it in case it causes noises to your experimentation. For the latter, I feel like the WASM run function may be better live in the Go SDK (But I'm totally fine if you want to have it land in this function). Just a note that before releasing set-namespace, we need to disable the warning message here.

@mengqiy mengqiy changed the title support compiling set-ns to wasm support compiling set-ns and set-labels to wasm Aug 9, 2022
Copy link
Copy Markdown
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on my side. Feel free to merge or update whatever it needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants