Skip to content
This repository was archived by the owner on Sep 6, 2020. It is now read-only.

Avoid calling cleanup twice on error condition - #20

Merged
koush merged 1 commit into
koush:masterfrom
ElMassimo:cleanup-called-twice
Jun 1, 2013
Merged

Avoid calling cleanup twice on error condition#20
koush merged 1 commit into
koush:masterfrom
ElMassimo:cleanup-called-twice

Conversation

@ElMassimo

Copy link
Copy Markdown

It's already being called in the onError method.

@koush

koush commented Jun 1, 2013

Copy link
Copy Markdown
Owner

From what I can tell, it doesn't call cleanup twice?

@ElMassimo

Copy link
Copy Markdown
Author

Check line 300.

@Override
public void onError(Exception error) {
    cleanup();
    mHandler.onError(error);
}

koush added a commit that referenced this pull request Jun 1, 2013
Avoid calling cleanup twice on error condition
@koush
koush merged commit 7ea59a8 into koush:master Jun 1, 2013
@ElMassimo
ElMassimo deleted the cleanup-called-twice branch June 2, 2013 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants