Fix crash in KSPlayer when reading video rotation from FFmpeg display matrix metadata. - #908
Merged
Merged
Conversation
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In FFmpegAssetTrack, rotation is parsed from AV_PKT_DATA_DISPLAYMATRIX and converted directly to Int:
rotation = Int16(Int(-av_display_rotation_get(matrix)) % 360)
For some streams, av_display_rotation_get(matrix) returns non-finite values (NaN / Infinity), which causes a runtime fatal error on Int(...) conversion:
Fatal error: Double value cannot be converted to Int because it is either infinite or NaN
Root Cause
No validation of Double finiteness before integer conversion.
Fix
Validate rotation value with isFinite before converting to Int.
Normalize finite values to [0, 359].
Fallback to 0 for invalid values.
Why this change
Prevents hard crash on malformed/invalid display matrix metadata and makes playback startup more robust for edge-case streams.
Impact
✅ Eliminates this crash path during media open.
✅ Keeps valid rotation behavior intact.
✅ Safe fallback for corrupted metadata.
Repro (before fix)
Open a stream/file containing invalid display matrix rotation metadata.
Player reaches FFmpegAssetTrack display matrix parsing.
App crashes with fatal Double -> Int conversion error.
Behavior after fix
Same stream opens without crash; rotation defaults safely when metadata is invalid.