test: make org.jbpm.kie.services.test.UserTaskServiceImplAuditNoneTest deterministic - #2491
Open
Jack-LuoHongyi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jbpm-services/jbpm-kie-servicesorg.jbpm.kie.services.test.UserTaskServiceImplAuditNoneTestRoot Cause
DeploymentDescriptorImplrelies onHashMapiteration order when emitting XML. Under NonDex the order changes, so the generated descriptor violates the schema and 30 tests fail in@Beforebefore any assertions run.Fix
Replace the dynamic descriptor builder with a static XML string that is identical to the original output (audit disabled, JPA persistence, singleton strategy, etc.), ensuring deterministic resources without touching the assertions or scenarios. The descriptor content, test inputs, coverage, and assertions stay exactly the same, only the HashMap-driven randomness is removed, so there is no reduction in scope or standard.
Validation
Risk
Low. Only the test fixture changes; it keeps the descriptor content intact while eliminating non-deterministic ordering.