Skip to content

Fixed a bug that reconnects DB every time when conn_id type is resource. - #301

Merged
kenjis merged 1 commit into
kenjis:masterfrom
ytetsuro:fix/reconnect-db-every-time-when-db-is-resouce
Jul 21, 2019
Merged

Fixed a bug that reconnects DB every time when conn_id type is resource.#301
kenjis merged 1 commit into
kenjis:masterfrom
ytetsuro:fix/reconnect-db-every-time-when-db-is-resouce

Conversation

@ytetsuro

Copy link
Copy Markdown
Contributor

DB_driver supported by CodeIgniter may include conn_id to resource.
And CIPHPUnitTestDbTestCase will reconnect if con_id is not an object.
Namely CIPHPUnitTestDbTestCase is every time reconnect when conn_id is resource.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 56.044% when pulling 4dec55b on ytetsuro:fix/reconnect-db-every-time-when-db-is-resouce into 3f2ea5c on kenjis:master.

@kenjis
kenjis merged commit 15d4616 into kenjis:master Jul 21, 2019
kenjis added a commit that referenced this pull request Jul 21, 2019
…n-db-is-resouce

Fixed a bug that reconnects DB every time when conn_id type is resource.
@ytetsuro

Copy link
Copy Markdown
Contributor Author

thanks merged.

@kenjis kenjis added the bug label Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants