Add function to detect errors in request output - #235
Merged
Conversation
Not to call header() function
kenjis
force-pushed
the
add-detect-errors-in-request
branch
from
March 19, 2018 13:15
c483986 to
67b06f7
Compare
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a warning in a request output, you can't notice it when you use
$this->request().This PR enables ci-phpunit-test detects such a warning or notice, and throws an exception.
By default, the error checking is enabled. This is BC break.
If you want to disable the checking, you must add
$strictRequestErrorCheck = falsein your test class like this: https://github.com/kenjis/ci-app-for-ci-phpunit-test/blob/master/application/tests/controllers/api/Example_test.php#L13