Skip inserting entries that do not fit in the encoding table - #28
Merged
kazu-yamamoto merged 2 commits intoJun 10, 2021
Merged
Conversation
The workaround introduced by kazu-yamamoto#17 makes a server use a default table size when creating response headers, even if the client requested size 0. This has the consequence that header entries are incorrectly added to the table, and can therefore be referenced by successive responses, causing the client to fail parsing the response. This patch simply skips adding an entry to the table if it doesn't fit.
kazu-yamamoto
self-requested a review
June 9, 2021 23:33
Owner
|
Thank you for your contribution! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 12, 2022
3.0.3 * Return correct status messages in HTTP2 client (#31)[kazu-yamamoto/http2#31] * Follow changes in Aeson 2 (#32)[kazu-yamamoto/http2#32] * Make sure connection preface is always sent first (#33)[kazu-yamamoto/http2#33] * Avoid empty data (#34)[kazu-yamamoto/http2#34] 3.0.2 * Skip inserting entries that do not fit in the encoding table (#28)[kazu-yamamoto/http2#28]
msk
pushed a commit
to msk/pkgsrc
that referenced
this pull request
May 11, 2026
3.0.3 * Return correct status messages in HTTP2 client (NetBSD#31)[kazu-yamamoto/http2#31] * Follow changes in Aeson 2 (NetBSD#32)[kazu-yamamoto/http2#32] * Make sure connection preface is always sent first (NetBSD#33)[kazu-yamamoto/http2#33] * Avoid empty data (NetBSD#34)[kazu-yamamoto/http2#34] 3.0.2 * Skip inserting entries that do not fit in the encoding table (NetBSD#28)[kazu-yamamoto/http2#28]
jperkin
pushed a commit
to TritonDataCenter/pkgsrc
that referenced
this pull request
May 14, 2026
3.0.3 * Return correct status messages in HTTP2 client (#31)[kazu-yamamoto/http2#31] * Follow changes in Aeson 2 (#32)[kazu-yamamoto/http2#32] * Make sure connection preface is always sent first (#33)[kazu-yamamoto/http2#33] * Avoid empty data (#34)[kazu-yamamoto/http2#34] 3.0.2 * Skip inserting entries that do not fit in the encoding table (#28)[kazu-yamamoto/http2#28]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #27. The new tests show that encoding with a 0-size table prevents the encoder from creating indexed fields that point to entries in the dynamic table.
I also reverted the workaround for #16 introduced in PR #17. Tests still pass.