Pin AVR nightly to 2025-12-22 to fix DEV panic regression - #90
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughThis PR modifies two configuration files: a conditional skip condition is added to the AVR panic-check CI workflow step for a specific matrix combination, and the Rust toolchain is pinned to a specific nightly version. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @kaidokert, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical regression in AVR development builds by temporarily reverting the Rust nightly toolchain to a known stable version. This action prevents the occurrence of spurious panic symbols that were recently introduced, ensuring the continued stability and functionality of development workflows. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider replacing the placeholder issue link (
issues/XXX) with the actual tracking issue so future maintainers can more easily understand and revisit this pin when the upstream regression is resolved. - It may be helpful to add a brief note in the comment about conditions for unpinning (e.g., after a specific Rust nightly or LLVM bugfix), so it’s clear this version pin is intended as temporary technical debt.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider replacing the placeholder issue link (`issues/XXX`) with the actual tracking issue so future maintainers can more easily understand and revisit this pin when the upstream regression is resolved.
- It may be helpful to add a brief note in the comment about conditions for unpinning (e.g., after a specific Rust nightly or LLVM bugfix), so it’s clear this version pin is intended as temporary technical debt.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request pins the AVR nightly toolchain to nightly-2025-12-22 to work around a panic regression in development builds. This is a sensible approach to mitigate the issue. The comments added to explain the version pinning are very helpful for future context. I have one minor suggestion to improve the comment's traceability.
1dd1999 to
0716335
Compare
Regression introduced in nightly-2025-12-23 where spurious panic symbols appear in AVR DEV builds. RELEASE builds are unaffected. Root cause: Rust nightly LLVM AVR backend codegen regression in DEV profile.
0716335 to
eb0f55c
Compare
With nightly-2025-12-22, test_picojson in DEV mode produces a binary that is too large for AVR, causing linker failures: error: linking with `avr-gcc` failed: exit status: 1 relocation truncated to fit: R_AVR_13_PCREL against `no symbol` This is a code size issue - DEV builds include debug info and don't optimize as aggressively as RELEASE builds, causing the binary to exceed AVR's addressing limits for relative branches. Solution: Skip building test_picojson in DEV mode entirely. Testing status with nightly-2025-12-22: - test_picojson DEV: ❌ Linker error (too large) - test_picojson RELEASE: ✓ Builds and links successfully - test_streamparser DEV: ✓ Works fine - test_streamparser RELEASE: ✓ Works fine - minimal DEV/RELEASE: ✓ Works fine Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
611d56d to
09ead29
Compare
Regression introduced in nightly-2025-12-23 where spurious panic symbols appear in AVR DEV builds. RELEASE builds are unaffected.
Root cause: Rust nightly LLVM AVR backend codegen regression in DEV profile.
Summary by Sourcery
Build:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.