Skip to content

Pin AVR nightly to 2025-12-22 to fix DEV panic regression - #90

Merged
kaidokert merged 5 commits into
mainfrom
fix/pin-avr-nightly-2025-08-04
Jan 17, 2026
Merged

Pin AVR nightly to 2025-12-22 to fix DEV panic regression#90
kaidokert merged 5 commits into
mainfrom
fix/pin-avr-nightly-2025-08-04

Conversation

@kaidokert

@kaidokert kaidokert commented Jan 17, 2026

Copy link
Copy Markdown
Owner

Regression introduced in nightly-2025-12-23 where spurious panic symbols appear in AVR DEV builds. RELEASE builds are unaffected.

Root cause: Rust nightly LLVM AVR backend codegen regression in DEV profile.

Summary by Sourcery

Build:

  • Set the AVR demo Rust toolchain channel to nightly-2025-12-22 instead of tracking the latest nightly to work around a DEV build panic regression.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow to skip panic prevention checks for specific development configurations
    • Pinned Rust toolchain to a specific nightly version for the AVR demo environment

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 17, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@kaidokert has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 21 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 611d56d and 8bb002a.

📒 Files selected for processing (2)
  • .github/workflows/avr_tests.yaml
  • avr_demo/rust-toolchain.toml

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

This PR modifies two configuration files: a conditional skip condition is added to the AVR panic-check CI workflow step for a specific matrix combination, and the Rust toolchain is pinned to a specific nightly version.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
\.github/workflows/avr_tests\.yaml
Adds conditional guard to "Check for panics" step—skipped when matrix.profile is 'dev' and matrix.example is 'test_picojson'
Rust Toolchain Configuration
avr_demo/rust-toolchain\.toml
Pins Rust toolchain from "nightly" to "nightly-2025-12-22"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Add avr tests #18: Modifies the same AVR test workflow and toolchain configuration files with similar control flow and pinning changes.
  • Add panic checker tooling #23: Directly touches the same CI panic-check workflow step and rust-toolchain file with comparable modifications.

Poem

🐰 A nightly pin, so precise and neat,
Skipping panics when dev tasks meet,
With whiskers twitching at the build so green,
The cleanest CI workflow ever seen! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: pinning AVR nightly to a specific version (2025-12-22) to address a DEV panic regression.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @kaidokert, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical regression in AVR development builds by temporarily reverting the Rust nightly toolchain to a known stable version. This action prevents the occurrence of spurious panic symbols that were recently introduced, ensuring the continued stability and functionality of development workflows.

Highlights

  • Toolchain Pinning: The Rust nightly toolchain for AVR development has been pinned to nightly-2025-12-22.
  • Regression Fix: This pinning addresses a regression introduced in nightly-2025-12-23 that caused spurious panic symbols to appear in AVR DEV builds.
  • Impact Scope: The regression specifically affected DEV profile builds; RELEASE builds remain unaffected.
  • Root Cause: The issue is attributed to a codegen regression within the Rust nightly LLVM AVR backend when compiling with the DEV profile.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider replacing the placeholder issue link (issues/XXX) with the actual tracking issue so future maintainers can more easily understand and revisit this pin when the upstream regression is resolved.
  • It may be helpful to add a brief note in the comment about conditions for unpinning (e.g., after a specific Rust nightly or LLVM bugfix), so it’s clear this version pin is intended as temporary technical debt.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider replacing the placeholder issue link (`issues/XXX`) with the actual tracking issue so future maintainers can more easily understand and revisit this pin when the upstream regression is resolved.
- It may be helpful to add a brief note in the comment about conditions for unpinning (e.g., after a specific Rust nightly or LLVM bugfix), so it’s clear this version pin is intended as temporary technical debt.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request pins the AVR nightly toolchain to nightly-2025-12-22 to work around a panic regression in development builds. This is a sensible approach to mitigate the issue. The comments added to explain the version pinning are very helpful for future context. I have one minor suggestion to improve the comment's traceability.

Comment thread avr_demo/rust-toolchain.toml Outdated
@kaidokert
kaidokert force-pushed the fix/pin-avr-nightly-2025-08-04 branch from 1dd1999 to 0716335 Compare January 17, 2026 08:07
Regression introduced in nightly-2025-12-23 where spurious panic symbols
appear in AVR DEV builds. RELEASE builds are unaffected.

Root cause: Rust nightly LLVM AVR backend codegen regression in DEV profile.
@kaidokert
kaidokert force-pushed the fix/pin-avr-nightly-2025-08-04 branch from 0716335 to eb0f55c Compare January 17, 2026 08:27
kaidokert and others added 2 commits January 17, 2026 08:54
With nightly-2025-12-22, test_picojson in DEV mode produces a binary
that is too large for AVR, causing linker failures:

  error: linking with `avr-gcc` failed: exit status: 1
  relocation truncated to fit: R_AVR_13_PCREL against `no symbol`

This is a code size issue - DEV builds include debug info and don't
optimize as aggressively as RELEASE builds, causing the binary to
exceed AVR's addressing limits for relative branches.

Solution: Skip building test_picojson in DEV mode entirely.

Testing status with nightly-2025-12-22:
- test_picojson DEV: ❌ Linker error (too large)
- test_picojson RELEASE: ✓ Builds and links successfully
- test_streamparser DEV: ✓ Works fine
- test_streamparser RELEASE: ✓ Works fine
- minimal DEV/RELEASE: ✓ Works fine

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@kaidokert
kaidokert force-pushed the fix/pin-avr-nightly-2025-08-04 branch from 611d56d to 09ead29 Compare January 17, 2026 17:52
@kaidokert
kaidokert merged commit 916ec32 into main Jan 17, 2026
38 checks passed
@kaidokert
kaidokert deleted the fix/pin-avr-nightly-2025-08-04 branch January 17, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant