This repository was archived by the owner on Dec 5, 2019. It is now read-only.
Add offline fetch of repository error to view model errors signal - #19
Open
stevemoser wants to merge 3 commits into
Open
Add offline fetch of repository error to view model errors signal#19stevemoser wants to merge 3 commits into
stevemoser wants to merge 3 commits into
Conversation
Owner
There was a problem hiding this comment.
Can you fix the indentation here to use tabs instead of spaces?
Owner
|
Thanks! Just a couple notes. |
Author
|
Np. I think I fixed the white space, let me know otherwise. Not sure as I never use tabs with Xcode. |
Owner
|
Yep, the indentation is certainly fixed, but there was a note about the threading too (regarding
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is the right way to fix the offline error but it fixes #16 for me. Also it seems the the error alert view eventually appears but not instantly, probably because [alert show] isn't on the main thread. 🍻