Cap grapheme final width at 2 (foot, ghostty, terminal.exe) - #224
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 1513 1566 +53
Branches 364 388 +24
=========================================
+ Hits 1513 1566 +53 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
From, ghostty-org/ghostty#10465 (comment) ghostty, foot, and windows terminal all "cap" the final grapheme width to 2 cells for cursor advance. Even if sometimes they "spill out" and over adjacent cells, the measurement of cursor advance is limited to 2. <img width="800" height="228" alt="image" src="https://github.com/user-attachments/assets/00821b21-97c0-4a69-a196-a6fe2a8c548d" /> <img width="1024" height="159" alt="image" src="https://github.com/user-attachments/assets/a6106e6c-5519-4498-9a7d-fa28dc256787" />
jquast
force-pushed
the
jq/grapheme-width-cap-2
branch
from
June 5, 2026 04:21
c4b0aa3 to
05d94bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From, ghostty-org/ghostty#10465 (comment)
ghostty, foot, and windows terminal all clip all final grapheme widths to 2 cells for cursor advance.
Even though they "spill" out and over adjacent cells, the measurement of cursor advance is limited to 2 by their engines.
ghostty (2):
foot (2):
