Skip to content
This repository was archived by the owner on Sep 17, 2018. It is now read-only.

Final Product - #39

Merged
astridx merged 66 commits into
masterfrom
final
Jul 18, 2018
Merged

Final Product #39
astridx merged 66 commits into
masterfrom
final

Conversation

@anuragteapot

Copy link
Copy Markdown
Member

Pull Request for Issue #38

Summary of Changes

Features added in Improve Override Management

1. Core and Diff view
screenshot from 2018-07-17 14-42-55

2. Updated override history list.
screenshot from 2018-07-17 14-43-37

3. Quick icon notification plugin.
screenshot from 2018-07-17 14-05-12

Installer override plugin must enabled to fetch result. And show in quick icon.
screenshot from 2018-07-17 01-55-56

4. Override control plugin.
screenshot from 2018-07-17 01-56-38
screenshot from 2018-07-17 14-47-26

Testing Instructions

1. Create override from this override list from create override tab.
screenshot from 2018-07-17 14-54-34

  1. Then, try to update you extension for which you created the override by any of them.
    A. Extension Install
    B. Extension Update
    C. Joomla Update

  2. If any override core files is got an update the you will receive message after update. And, when you visit control panel you will see quick icon response after update.

  3. Then, visit to your template settings you will see. A tab with updated files which contains list of updated file with belongs to current template.

Note: During this project new feature is introduced.
To support more than two form in one page with different id
PR for this #36

Documentation Changes Required

Yes

@anuragteapot
anuragteapot requested review from astridx and laoneo July 17, 2018 09:55
@anuragteapot anuragteapot added the feature New feature label Jul 17, 2018
@anuragteapot anuragteapot self-assigned this Jul 17, 2018
@astridx

astridx commented Jul 18, 2018

Copy link
Copy Markdown
Contributor
  1. I changed to this branch and made a new installation.

  2. I see the plugins, the quickicon and the view
    control panel test administration 2
    plugins test administration 1
    templates customise cassiopeia test administration 22

  3. I installed a template, a module and a component.
    com_agosms-1.0.27.zip
    mod_agosm-1.0.27.zip
    tpl_agfirework_20180624_1525.zip

  4. I created an override of the view agsom in the component for one template and an override of the module view in the other template.

  5. I changed both views. I see the changes in the "diff view". I see nothing in the "updated files" view, because here the files are only added via update.

templates customise agfirework test administration 3

  1. I made an update of the module via joomla updater and a new install of v.28 of the component.
    com_agosms-1.0.28.zip
    extensions update test administration
    extensions update test administration 1
    extensions install test administration 1

  2. The override files are in the correct views. I am surprised by the date of the first entry in the list. The date last change via update is certainly correct. Should not the dates be the same?
    templates customise agfirework test administration 4
    templates customise cassiopeia test administration 23

  3. In control panel I see a red quickicon.
    control panel test administration 3

  4. I am able to check and unckeck an entry in the view updated list. After an action I am redirected to the fist tab. But this is a problem of the frontend template.
    templates customise cassiopeia test administration 24

  5. I I check all entries in all templates the quickicon is green again.

  6. I am able to delete a file via toolbar button "delete".
    templates customise agfirework test administration 6

  7. If i deactivate the installer override plugin I see a quickicon with a message.
    control panel test administration 4

@anuragteapot

Copy link
Copy Markdown
Member Author
  1. The override files are in the correct views. I am surprised by the date of the first entry in the list. The date last change via update is certainly correct. Should not the dates be the same?

Because last change via update is date of the actual file and Added to list is is server time.

I am also a little bit confused here. Should we use server time for both ?

@astridx

astridx commented Jul 18, 2018

Copy link
Copy Markdown
Contributor

I am also a little bit confused here. Should we use server time for both ?

I opened an issue for this, so that we not forget ...

@astridx
astridx merged commit ef31722 into master Jul 18, 2018
@astridx
astridx deleted the final branch July 18, 2018 09:54
zero-24 pushed a commit that referenced this pull request Sep 6, 2018
* Load correct core files of override files (#2)

Start implements loadcorefile() in administrator/components/com_templates/Model/TemplateModel.php

* CS (#3) Coding Standards

* codingstandards

* codingstandards (#4)

* Test (#6)

Phase 2 (2 part) Mechanism to find correct core file and implementation.

* Remove Notice: Only available for html-folder

* Remove Warning if core file not found (#11)

Thanks.
So one part of the issue #12 is done.

* Implement the diff view in template manager 

Implement the diff view in template manager

* coding standard (#17)

* fix diff (#18) Fix bug in path in case of administrator template override.

Fix bug in path in case of administrator template override.

* Notification after update and TEST (#16)

Find changed files of overridden files and show message.

* coding standard (#21)

* correction

* correction (#26)

* Correcthtmlpath (#27)

* correction

* change oldhtml to newhtml

* List of updated override files. (#30)

* addcss (#34)

* Final Product  (#39)

Core and Diff view
Updated override history list.
Quick icon notification plugin.
Override control plugin.

* save 3 lines :)

* New feature show status. (#47)

show status in com_template view templates

* link

* corrected namespace

* Button to Switch (#35)

* wip add Switcher

* wip style switcher

* wip style switch make inline and change on off text

* wip start with js

* wip js

* wip delete buttons and make js more robust

* wip save to storage

* wip delete old code

* wip

* wip lint

* wip css

* set default value for switcher

* wip make switcher blue

* wip

* wip

* build

* correct names

* create new functions

* fist test code

* use onchange

* undo installer.min.js

* add forgotten new line at the end of css file

* correct align

* correct compare.es6 - only deleted the toggle part

* correct compare.js - only deleted the toggle part

* wip

* reduce timeout

* wrap in funcitons

* wip

* add use strict to both js-files(compare and toggle)

* add the timeout value of 500 again, because 200 are not enought in my case

* use css class 'active' for toggle views

* add strict

* time out for editor

* wip

* improvments use newActive and switch

* correction

* width of switcher-spans

* correct align

* do not use global

* wip

* removed timeouts

* JTEXT to TEXT

* forgotton last line

* deleted duplicated comments

* css fix align

* use unnamed functions in es6

* Sql files for fix database (#50)

* sql files for database fix

* delete space

* Suggestion for displaying Dates in view updates files (#52)

Correct Dates and do not use date of file any more

* Store Date as UTC and show it in server time zone (#57)

* modified and created date are created and stored in UTC

* convert dates for displaying in model

* spar a loop

* normalize timezone in view

* use language constants for dateformat

* JToolbarHelper to ToolbarHelper

* CS

* namespace

* plural

* name

* clean

* text

* fx

* sin

* files

* s

* Suggestion for language strings (#60)

* language strings

* correct typo

* delete media folder plg_quickicon

* add folder plg_quickicon to build/media_src

* delete files in media folder

* Move media folder - System (#66)

* multi

* cs

* delete files in media folder for joomla toolbar (#67)

* Fix button switchers style. (#70)

* button

* CS

* changed uitab.addTab for updated files

* Bring back core.js changes. (#69)

* core.js

* const

* fix

* form

* core

* hound

* CS

* scopr

* grid

* alpha

* cs

* lang

* only override file

* lang

* override lang installer

* Cs

* sub

* Update list of core extensions (#71)

* Language changes (#76)

* update

* Update en-GB.com_templates.ini

* override JLIB_HTML_PUBLISH_ITEM

this is the hover text on the publish icon in the list of files

* Change icon (#74)

change the icon to use an outline for more consistency

* lang

* not core (#75)

* not core

* Update en-GB.plg_installer_override.ini

* namespace

* cs

* Updated files (#82)

* Update default_updated_files.php

* Update en-GB.com_templates.ini

* Update en-GB.com_templates.ini (#81)

* Update en-GB.plg_quickicon_overridecheck.ini (#80)

* Update en-GB.plg_quickicon_overridecheck.ini (#79)

* remove space (#78)

* Update en-GB.plg_quickicon_overridecheck.ini

* Update en-GB.plg_quickicon_overridecheck.sys.ini

* remove hardcoded id

* null get function

* state

* clean

* More changes "core" to "original" (#85)

* cs

* update

* plural
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants