refactor publisher connection logic - #325
Merged
Merged
Conversation
aiomaster
commented
Oct 30, 2017
aiomaster
commented
Contributor
- separate connection stuff from publish method to better reuse Sneakers::Publisher for own derived classes
- fix warning: instance variable @bunny not initialized when connected? is called
* separate connection stuff from publish method to better reuse Sneakers::Publisher for own derived classes * fix warning: instance variable @bunny not initialized when connected? is called
this way we can do something with the connection before publishing
* use timeout and retry if expected consumers are not there * refactor rabbitmq stuff a little in integration spec
Collaborator
|
Thanks a lot for ac2d572. |
michaelklishin
approved these changes
Nov 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.