feat(tsconfig-loader): extends config from node_modules - #106
Merged
Conversation
…de_modules' prefix
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 4 4
Lines 129 129
Branches 52 52
=====================================
Misses 129 129Continue to review full report at Codecov.
|
yusufkandemir
approved these changes
Jul 6, 2021
yusufkandemir
left a comment
There was a problem hiding this comment.
Look good to me, tested it locally and confirm that it works as expected 🚀 Thanks, @zorji. @Jontem @jonaskello kind ping to remind about the existence of this PR.
Owner
|
Ok let's merge this :-) |
Owner
|
Released in 3.10.0. |
Contributor
Author
|
I am using this change but I found that it's still broken for eslint because I also need to fix I'll create a PR later today or tomorrow. |
This was referenced Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, when an extends path is specified, the extends path has to be relative to the overriding
tsconfig.jsonfile.However, in the implementation of
tsc --showConfig, it also supports search fromnode_modulesin the same current directory.e.g.
If a base file exists in
node_modules/my-package/tsconfig.base.json.Both
and
have the same effect.
Because
tscbehaves like this,tsconfig-pathsshould be consistent.