Skip to content

Fix multipart uploads with boolean params. - #575

Merged
jnunemaker merged 1 commit into
jnunemaker:masterfrom
combinaut:fix-boolean-params
Feb 27, 2018
Merged

Fix multipart uploads with boolean params.#575
jnunemaker merged 1 commit into
jnunemaker:masterfrom
combinaut:fix-boolean-params

Conversation

@rywall

@rywall rywall commented Feb 24, 2018

Copy link
Copy Markdown
Contributor

I am using a gem (ocr_space) that passes a boolean param to HTTParty.post. This started failing in v0.16 with the following error message:

TypeError: no implicit conversion of false into String
from /gems/httparty-0.16.0/lib/httparty/request/body.rb:40:in `+'

@jnunemaker

Copy link
Copy Markdown
Owner

I'm going to merge this. I have some hesitation adding the to_s as it could cover up passing in nil or other not serializable objects accidentally, but we'll see how it goes. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants