Initialize HTTParty requests with an URI object and a String. - #274
Merged
Conversation
Owner
|
Seems sane. Not sure why we would force to_s. I'll merge and hope I don't break anything. :) |
jnunemaker
pushed a commit
that referenced
this pull request
Mar 3, 2014
Initialize HTTParty requests with an URI object and a String.
Contributor
Author
|
@jnunemaker thanks! FYI: here's the "why" for the irb(main):001:0> require 'uri'
=> true
irb(main):002:0> google = URI.parse('http://google.com/')
=> #<URI::HTTP:0x007fe4821a1620 URL:http://google.com/>
irb(main):003:0> URI(google) # The new way, it just works!
=> #<URI::HTTP:0x007fe4821a1620 URL:http://google.com/>
irb(main):004:0> URI.parse(google) # Oh no! URI.parse requires a string
URI::InvalidURIError: bad URI(is not URI?): http://google.com/
from /Users/bradgessler/.rbenv/versions/2.1.0/lib/ruby/2.1.0/uri/common.rb:176:in `split'
from /Users/bradgessler/.rbenv/versions/2.1.0/lib/ruby/2.1.0/uri/common.rb:211:in `parse'
from /Users/bradgessler/.rbenv/versions/2.1.0/lib/ruby/2.1.0/uri/common.rb:747:in `parse'
from (irb):4
from /Users/bradgessler/.rbenv/versions/2.1.0/bin/irb:11:in `<main>'
irb(main):005:0> URI.parse(google.to_s) # Ewww...
=> #<URI::HTTP:0x007fe481967ef0 URL:http://google.com/>URI.parse demands a string, URI is cool with a string and an URI. |
Owner
|
Yep, I got what you were saying. It really should be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
URI.parse(uri)toURI(uri)so that HTTParty consuming code can make requests with:as opposed to
without throwing and invalid URI exception.