Don't duplicate query string arguments. - #189
Merged
jnunemaker merged 1 commit intoFeb 2, 2013
Merged
Conversation
During the course of an actual request, the Request#uri method is called more than once. If the request's path is not relative, that method destructively updates @path, and so parameters get duplicated each time uri is called. This change clones the path first (and adds a lame test).
jnunemaker
pushed a commit
that referenced
this pull request
Feb 2, 2013
Don't duplicate query string arguments.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #185.
During the course of an actual request, the Request#uri method is called more
than once. If the request's path is not relative, that method destructively
updates
@path, and so parameters get duplicated each time uri is called. Thischange clones the path first (and adds a lame test).