Add support for custom http connection factories - #157
Conversation
|
no fair travis! the build failed because of a vagrant error, not a code problem. :( |
|
@jnunemaker, let me know when you think and if you want me to send you another pull request with the commits squashed. Also, I'm planning on writing a connection adapter that does persistent http connections using the persistent_http gem. Would you be interested in having that be a part of httparty? Let me know as I'll release it as a separate gem otherwise. |
|
Definitely separate. I'd like to keep dependencies to a minimum. On Aug 13, 2012, at 7:44 PM, Matt Campbell notifications@github.com wrote:
|
|
@jnunemaker, is there any other changes you would want to this pull request? I am hoping to release a gem that uses this feature to enable persistent http connections in the next week or two. |
|
Looking it over now. |
|
thx! |
I followed the same pattern used for the parser. This opens the door to being able to do things like use a pool of persistent HTTP connections. Let me know what you think and if there are any changes you would like to see.