Skip to content

Add support for custom http connection factories - #157

Merged
jnunemaker merged 2 commits into
jnunemaker:masterfrom
vibes:custom_http_connection_factory
Sep 7, 2012
Merged

Add support for custom http connection factories#157
jnunemaker merged 2 commits into
jnunemaker:masterfrom
vibes:custom_http_connection_factory

Conversation

@elspethsoup

Copy link
Copy Markdown
Contributor

I followed the same pattern used for the parser. This opens the door to being able to do things like use a pool of persistent HTTP connections. Let me know what you think and if there are any changes you would like to see.

@travisbot

Copy link
Copy Markdown

This pull request fails (merged 22bd579 into 9c08f47).

@elspethsoup

Copy link
Copy Markdown
Contributor Author

no fair travis! the build failed because of a vagrant error, not a code problem. :(

@elspethsoup

Copy link
Copy Markdown
Contributor Author

@jnunemaker, let me know when you think and if you want me to send you another pull request with the commits squashed.

Also, I'm planning on writing a connection adapter that does persistent http connections using the persistent_http gem. Would you be interested in having that be a part of httparty? Let me know as I'll release it as a separate gem otherwise.

@jnunemaker

Copy link
Copy Markdown
Owner

Definitely separate. I'd like to keep dependencies to a minimum.

On Aug 13, 2012, at 7:44 PM, Matt Campbell notifications@github.com wrote:

@jnunemaker, let me know when you think and if you want me to send you another pull request with the commits squashed.

Also, I'm planning on writing a connection adapter that does persistent http connections using the persistent_http gem. Would you be interested in having that be a part of httparty? Let me know as I'll release it as a separate gem otherwise.


Reply to this email directly or view it on GitHub.

@elspethsoup

Copy link
Copy Markdown
Contributor Author

@jnunemaker, is there any other changes you would want to this pull request? I am hoping to release a gem that uses this feature to enable persistent http connections in the next week or two.

@jnunemaker

Copy link
Copy Markdown
Owner

Looking it over now.

@jnunemaker
jnunemaker merged commit 22bd579 into jnunemaker:master Sep 7, 2012
@elspethsoup

Copy link
Copy Markdown
Contributor Author

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants