Add new "instance" object and use it for instance name propagation#77
Merged
Conversation
6543
commented
Dec 6, 2023
Contributor
Author
about limit lengththe-federation.info database has this: select node.domain,LENGTH(d::text) as l from (select node_id,data->'metadata'->'nodeName'::text as d from node_info where data->'metadata'->'nodeDescription' IS NOT NULL) JOIN node on node.id=node_id order by l desc limit 30; |
Contributor
Author
|
Contributor
Author
|
I propose limit of 500 , so #78 would be exactly 10x |
Contributor
Author
|
@jhass request your comments :) |
Contributor
Author
|
@jhass added max length of 500 to it |
jhass
reviewed
Dec 10, 2023
jhass
left a comment
jhass
left a comment
Owner
There was a problem hiding this comment.
While the instance.name property itself should obviously be optional, I'd actually favor to make the instance object itself mandatory. That is I think it would be preferable for an instance without a configured name to expose "instance": {} or "instance: { "name": null } always, such that a client who validated the response against the schema can be sure to always have an object at instance and save a null check.
Co-authored-by: Jonne Haß <me@jhass.eu>
Contributor
Author
|
squash-merged your changes and made instance required |
pfefferle
reviewed
Dec 11, 2023
| ] | ||
| }, | ||
| "instance":{ | ||
| "description": "Metadata specific to the instance. An instance is a the concrete installation of a software running on a server.", |
Contributor
There was a problem hiding this comment.
There is a typo An instance is a the concrete [...]!
Owner
There was a problem hiding this comment.
Ups, sorry, mind opening a follow up? 😇
Contributor
Author
There was a problem hiding this comment.
Uh sorry I'm bad at typos too 😓
We migt at cSpell linter?
PS: @pfefferle if you want just open a pull ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move wily used
nodeNameinto the normal spec.this also should contain more instance configured specific information.