[PM Fixer] Add pnpm 12.x case to TestPnpmVersionValidation

[agrasth]

Summary

TestPnpmVersionValidation already asserts pnpm 10.x and 11.x meet minSupportedPnpmVersion's floor, explicitly documenting "no upper bound" for the 11.x case. pnpm 12.x is now the actual latest tested version (jfrog/jfrog-cli#3692 fixed a real pnpm 12 compatibility bug), so this extends the same explicit pattern to 12.x.

Fix

Added a pnpm12 := version.NewVersion("12.2.1") case to TestPnpmVersionValidation, mirroring the existing pnpm10/pnpm11 cases exactly.

Compatibility impact

Test-only change. No production code touched, no exported symbols changed.

Test plan

• go test ./artifactory/commands/pnpm/... -run TestPnpmVersionValidation -v — passes
• go test ./artifactory/commands/pnpm/... (full package) — passes
• gofmt -l, go vet ./..., go build ./... — all clean

---

Opened by PM Compat Fixer follow-up, prompted by review of jfrog/jfrog-cli#3692.

Summary by CodeRabbit

• Tests
  • Added coverage confirming that pnpm version 12.2.1 meets the minimum supported version requirement.

[coderabbitai]

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 173ec997-b0ca-49ee-a34e-c5670bdba48d

📥 Commits

Reviewing files that changed from the base of the PR and between 4c19791 and f91cb4b.

📒 Files selected for processing (1)

• artifactory/commands/pnpm/pnpm_test.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The pnpm test suite adds validation coverage for version 12.2.1. The case confirms that the version meets the minimum supported pnpm version without an upper-version restriction.

Changes

pnpm version validation

Layer / File(s)	Summary
pnpm 12 validation test artifactory/commands/pnpm/pnpm_test.go	Adds a test case that accepts pnpm version 12.2.1 without an upper-version restriction.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f91cb

This test-only change confirms pnpm 12.2.1 satisfies the existing minimum-version rule and is ready to merge.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a pnpm 12.x test case to TestPnpmVersionValidation.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch RTECO-1037-pnpm12-version-test

---

_{Comment @coderabbitai help to get the list of available commands.}

[fluxxBot]

not correct

[agrasth]

Closing - this was based on a misread of what was actually needed. The real gap is jfrog-cli's own CI test matrix (hardcoded to pnpm 10/11, never testing 12 on regular PR merges), not this floor-check test, which is redundant with the existing 'no upper bound' pnpm11 case. Fixed properly in jfrog/jfrog-cli#3705.