Skip to content

Moves to AWSSDK 4.x#480

Merged
bartelink merged 5 commits into
jet:masterfrom
njlr:infra/bump-aws-sdk-version
Feb 4, 2026
Merged

Moves to AWSSDK 4.x#480
bartelink merged 5 commits into
jet:masterfrom
njlr:infra/bump-aws-sdk-version

Conversation

@njlr

@njlr njlr commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

This PR bumps FSharp.AWS.DynamoDB and AWSSDK.SecurityToken dependencies so that consumers can upgrade to latest versions (4.*) of AWSSDK packages.

Related: fsprojects/FSharp.AWS.DynamoDB#84

@CLAassistant

CLAassistant commented Feb 3, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@bartelink

bartelink commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

Thanks; will get this released shortly (I have a similar set of local diffs that I forgot about)
If you get a chance, can you add a changelog entry please (I'll add after the merge if I get here first)
(Will also be doing same for Propulsion components)

@njlr

njlr commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks; will get this released shortly (I have a similar set of local diffs that I forgot about) If you get a chance, can you add a changelog entry please (I'll add after the merge if I get here first) (Will also be doing same for Propulsion components)

Done - hopefully the format is correct!

Comment thread src/Equinox.DynamoStore/DynamoStore.fs Outdated
Comment thread CHANGELOG.md Outdated
njlr and others added 2 commits February 4, 2026 10:21
Co-authored-by: Ruben Bartelink <ruben@bartelink.com>
Co-authored-by: Ruben Bartelink <ruben@bartelink.com>
@bartelink
bartelink merged commit f40dcf9 into jet:master Feb 4, 2026
5 checks passed
@bartelink

Copy link
Copy Markdown
Collaborator

Thanks for the work - on nuget as Equinox.DynamoStore 4.2.0-rc.1

[<Struct>]
type RequestConsumption = { total: float }

[<Struct; RequireQualifiedAccess>]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njlr I'll probably leave this as this is in Equinox.DynamoStore.Core, a rarely-opened namespace, but here are some details on why this happened:

The error stems from using the V9/10 compiler where the assembly references FSharp.Core <8 - the RequireQualifiedAccessAttribute is missing AttributeTarget.Stuct and the compiler complains. The fix is to up the FSharp.Core dependency to v8 (or use the older compiler)

anything else makes the case values (Forward/Backward) visible in the default namespace, which might not be a breaking change from the point of view of the API Validation, but can easily be a source breaking change for F# consumers

A prime example of where this does not make sense is https://github.com/jet/propulsion/blob/908e84f237a1b43c2a39d430df3a388f6e63d06a/src/Propulsion/Streams.fs#L295

(If it wasnt a binary breaking change, I'd drop the Struct before the RQA)

@bartelink

Copy link
Copy Markdown
Collaborator

Thanks for the work - on nuget as Equinox.DynamoStore 4.2.0-rc.1

Note this has been unlisted since publish, tracked by #482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants