Moves to AWSSDK 4.x#480
Conversation
|
Thanks; will get this released shortly (I have a similar set of local diffs that I forgot about) |
Done - hopefully the format is correct! |
Co-authored-by: Ruben Bartelink <ruben@bartelink.com>
Co-authored-by: Ruben Bartelink <ruben@bartelink.com>
|
Thanks for the work - on nuget as |
| [<Struct>] | ||
| type RequestConsumption = { total: float } | ||
|
|
||
| [<Struct; RequireQualifiedAccess>] |
There was a problem hiding this comment.
@njlr I'll probably leave this as this is in Equinox.DynamoStore.Core, a rarely-opened namespace, but here are some details on why this happened:
The error stems from using the V9/10 compiler where the assembly references FSharp.Core <8 - the RequireQualifiedAccessAttribute is missing AttributeTarget.Stuct and the compiler complains. The fix is to up the FSharp.Core dependency to v8 (or use the older compiler)
anything else makes the case values (Forward/Backward) visible in the default namespace, which might not be a breaking change from the point of view of the API Validation, but can easily be a source breaking change for F# consumers
A prime example of where this does not make sense is https://github.com/jet/propulsion/blob/908e84f237a1b43c2a39d430df3a388f6e63d06a/src/Propulsion/Streams.fs#L295
(If it wasnt a binary breaking change, I'd drop the Struct before the RQA)
|
This PR bumps
FSharp.AWS.DynamoDBandAWSSDK.SecurityTokendependencies so that consumers can upgrade to latest versions (4.*) of AWSSDK packages.Related: fsprojects/FSharp.AWS.DynamoDB#84