Migrating from py-zabbix to python-zabbix-utils - #1722
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Zabbix alerter from the deprecated py-zabbix library to the modern zabbix-utils library (version 2.0.3+). The migration includes updating imports, class names, constructor parameters, and test expectations to align with the new library's API.
Key Changes:
- Replace
py-zabbixdependency withzabbix-utils>=2.0.3in package configuration - Update Zabbix alerter implementation to use new API (Sender, ItemValue, parameter names)
- Update test mocks and assertions to reflect the new library structure
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Updated dependency from py-zabbix>=1.1.7 to zabbix-utils>=2.0.3 |
| requirements.txt | Updated dependency from py-zabbix>=1.1.7 to zabbix-utils>=2.0.3 |
| elastalert/alerters/zabbix.py | Migrated imports and class usage from pyzabbix (ZabbixSender, ZabbixMetric) to zabbix_utils (Sender, ItemValue); updated constructor parameter names (zabbix_server→server, zabbix_port→port) |
| tests/alerters/zabbix_test.py | Updated test mocks from pyzabbix.ZabbixSender.send to zabbix_utils.Sender.send; added ns field to expected metrics to match ItemValue structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jertel
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since development of py-zabbix stopped in 2020, we switched to the official library python-zabbix-utils.
Checklist
make test-dockerwith my changes.Questions or Comments