Fix percentile metric_aggregation rule error for rules with compound query keys - #1701
Merged
jertel merged 1 commit intoSep 15, 2025
Conversation
jertel
approved these changes
Sep 15, 2025
Owner
|
Thanks for fixing this issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes metric_aggregation rules of type
percentile, when used with a compound query key.Prior to this fix, using such a rule would raise the following
KeyError:I was able to reproduce this issue with the following minimal example:
rule.yamlelastalert-test-rule rule.yaml --days 10KeyErroris observed without the fix, and alerts are fired as expected with the fix applied.Checklist
make test-dockerwith my changes.Questions or Comments