Skip to content

remove lineNotifyAlerter - #1638

Merged
jertel merged 8 commits into
jertel:masterfrom
nsano-rururu:remove_line
Mar 14, 2025
Merged

remove lineNotifyAlerter#1638
jertel merged 8 commits into
jertel:masterfrom
nsano-rururu:remove_line

Conversation

@nsano-rururu

@nsano-rururu nsano-rururu commented Mar 4, 2025

Copy link
Copy Markdown
Collaborator

Description

LINE Notify to end service at the end of March 2025

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu
nsano-rururu marked this pull request as draft March 4, 2025 17:48
@nsano-rururu

Copy link
Copy Markdown
Collaborator Author

sudo make test-docker is error

sano3@U-2D13W42JHXSRM:~/dkwork3/elastalert2$ sudo make test-docker
docker compose -f tests/docker-compose.yml --project-name elastalert build tox
unknown shorthand flag: 'f' in -f
See 'docker --help'.

Usage:  docker [OPTIONS] COMMAND

A self-sufficient runtime for containers

Common Commands:
  run         Create and run a new container from an image
  exec        Execute a command in a running container
  ps          List containers
  build       Build an image from a Dockerfile
  pull        Download an image from a registry
  push        Upload an image to a registry
  images      List images
  login       Log in to a registry
  logout      Log out from a registry
  search      Search Docker Hub for images
  version     Show the Docker version information
  info        Display system-wide information

Management Commands:
  builder     Manage builds
  container   Manage containers
  context     Manage contexts
  image       Manage images
  manifest    Manage Docker image manifests and manifest lists
  network     Manage networks
  plugin      Manage plugins
  system      Manage Docker
  trust       Manage trust on Docker images
  volume      Manage volumes

Swarm Commands:
  swarm       Manage Swarm

Commands:
  attach      Attach local standard input, output, and error streams to a running container
  commit      Create a new image from a container's changes
  cp          Copy files/folders between a container and the local filesystem
  create      Create a new container
  diff        Inspect changes to files or directories on a container's filesystem
  events      Get real time events from the server
  export      Export a container's filesystem as a tar archive
  history     Show the history of an image
  import      Import the contents from a tarball to create a filesystem image
  inspect     Return low-level information on Docker objects
  kill        Kill one or more running containers
  load        Load an image from a tar archive or STDIN
  logs        Fetch the logs of a container
  pause       Pause all processes within one or more containers
  port        List port mappings or a specific mapping for the container
  rename      Rename a container
  restart     Restart one or more containers
  rm          Remove one or more containers
  rmi         Remove one or more images
  save        Save one or more images to a tar archive (streamed to STDOUT by default)
  start       Start one or more stopped containers
  stats       Display a live stream of container(s) resource usage statistics
  stop        Stop one or more running containers
  tag         Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE
  top         Display the running processes of a container
  unpause     Unpause all processes within one or more containers
  update      Update configuration of one or more containers
  wait        Block until one or more containers stop, then print their exit codes

Global Options:
      --config string      Location of client config files (default
                           "/root/.docker")
  -c, --context string     Name of the context to use to connect to the
                           daemon (overrides DOCKER_HOST env var and
                           default context set with "docker context use")
  -D, --debug              Enable debug mode
  -H, --host list          Daemon socket to connect to
  -l, --log-level string   Set the logging level ("debug", "info",
                           "warn", "error", "fatal") (default "info")
      --tls                Use TLS; implied by --tlsverify
      --tlscacert string   Trust certs signed only by this CA (default
                           "/root/.docker/ca.pem")
      --tlscert string     Path to TLS certificate file (default
                           "/root/.docker/cert.pem")
      --tlskey string      Path to TLS key file (default
                           "/root/.docker/key.pem")
      --tlsverify          Use TLS and verify the remote
  -v, --version            Print version information and quit

Run 'docker COMMAND --help' for more information on a command.

For more help on how to use Docker, head to https://docs.docker.com/go/guides/

make: *** [Makefile:29: test-docker] エラー 125
sano3@U-2D13W42JHXSRM:~/dkwork3/elastalert2$ cat /etc/issue
Ubuntu 22.04.5 LTS \n \l

sano3@U-2D13W42JHXSRM:~/dkwork3/elastalert2$ docker-compose version
docker-compose version 1.29.2, build unknown
docker-py version: 5.0.3
CPython version: 3.10.12
OpenSSL version: OpenSSL 3.0.2 15 Mar 2022
sano3@U-2D13W42JHXSRM:~/dkwork3/elastalert2$ sudo docker version
Client:
 Version:           26.1.3
 API version:       1.45
 Go version:        go1.22.2
 Git commit:        26.1.3-0ubuntu1~22.04.1+esm1
 Built:             Mon Feb 17 06:07:24 2025
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          26.1.3
  API version:      1.45 (minimum version 1.24)
  Go version:       go1.22.2
  Git commit:       26.1.3-0ubuntu1~22.04.1+esm1
  Built:            Mon Feb 17 06:07:24 2025
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.7.24
  GitCommit:        
 runc:
  Version:          1.1.12-0ubuntu2~22.04.1
  GitCommit:        
 docker-init:
  Version:          0.19.0
  GitCommit:        
sano3@U-2D13W42JHXSRM:~/dkwork3/elastalert2$ 

@nsano-rururu

nsano-rururu commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator Author

Suggested makefile modifications

before

COMPOSE = "-compose"
$(which shell && shell docker$(COMPOSE) 2> /dev/null)
ifneq ($(.SHELLSTATUS),0)
	COMPOSE = " compose"
endif

after

COMPOSE = $(shell if docker compose version >/dev/null 2>&1; then echo " compose"; else echo "-compose"; fi)

@nsano-rururu
nsano-rururu marked this pull request as ready for review March 12, 2025 15:53
@nsano-rururu
nsano-rururu requested a review from jertel March 14, 2025 12:13
@jertel

jertel commented Mar 14, 2025

Copy link
Copy Markdown
Owner

Thanks for your continued help with maintaining this project @nsano-rururu !

@jertel
jertel merged commit 0646160 into jertel:master Mar 14, 2025
@nsano-rururu

Copy link
Copy Markdown
Collaborator Author

@jertel

Although LineNotify is no longer in service, there seems to be a LINE Messaging API. I'll look into it and if I can make it work, I'll submit a pull request.

@nsano-rururu
nsano-rururu deleted the remove_line branch March 14, 2025 12:28
@jertel jertel mentioned this pull request Nov 18, 2025
6 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants