Skip to content

Add Webex incoming webhook alerter - #1635

Merged
jertel merged 6 commits into
jertel:masterfrom
dennis-trapp:webex-incoming
Mar 6, 2025
Merged

Add Webex incoming webhook alerter#1635
jertel merged 6 commits into
jertel:masterfrom
dennis-trapp:webex-incoming

Conversation

@dennis-trapp

@dennis-trapp dennis-trapp commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

Description

Adds alerter support for Webex incoming webhook

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@jertel

jertel commented Mar 3, 2025

Copy link
Copy Markdown
Owner

Thanks for submitting this. Do you anticipate other webex alerters at some point in the future? I'm asking since you named the new one webex_incoming vs webex.

@dennis-trapp

Copy link
Copy Markdown
Contributor Author

There's also a bot functionality for webex https://developer.webex.com/docs/bots and I could see it potentially being added in the future. However I am not too familiar with it as of this moment.

I am open to re-naming the alerter to whatever makes the most sense.

@jertel

jertel commented Mar 4, 2025

Copy link
Copy Markdown
Owner

Ok, if there's also a bot option then I agree it's better not to name it just webex. webex_webhook might be more clear but it's not that important.

@dennis-trapp

Copy link
Copy Markdown
Contributor Author

webex_webhook makes sense. I'll make that change.

@jertel
jertel merged commit 55ccb06 into jertel:master Mar 6, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants