Skip to content

Fixing issue with invalid certificate test - #1834

Merged
krisstern merged 4 commits into
jenkinsci:masterfrom
alecharp:bug/certificate-not-found
Nov 6, 2025
Merged

Fixing issue with invalid certificate test#1834
krisstern merged 4 commits into
jenkinsci:masterfrom
alecharp:bug/certificate-not-found

Conversation

@alecharp

@alecharp alecharp commented Nov 6, 2025

Copy link
Copy Markdown
Member

Testing done

The test GitLabConnectionConfigSSLTest is failing in BOM (jenkinsci/bom#5931) but also locally on the current master branch.
This is to fix it.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@alecharp
alecharp requested a review from a team as a code owner November 6, 2025 10:17
@github-actions github-actions Bot added the tests This PR adds/removes/updates test cases label Nov 6, 2025
@alecharp

alecharp commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

@krisstern as this is possibly blocking BOM release later this week.

@alecharp

alecharp commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

Ok so there is more to it as Windows build still has the previous message.

@alecharp

alecharp commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

Original test passes on Java 17 but not 21/25.
Patch is fixing Java 21/25 but breaks 17. Working on it.

@alecharp

alecharp commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

Sorry for the force push, I didn't want to do yet-another-spotless-fix-commit.

@krisstern krisstern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisstern

Copy link
Copy Markdown
Member

Thanks so much @alecharp!

@krisstern
krisstern merged commit 9ab54f9 into jenkinsci:master Nov 6, 2025
18 checks passed
@alecharp
alecharp deleted the bug/certificate-not-found branch November 7, 2025 08:42
@MarkEWaite

Copy link
Copy Markdown
Contributor

@krisstern the plugin BOM test will continue to fail on this test until a new plugin release has been created that includes this fix. Are you available to create the plugin release or would you prefer that I create the plugin release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests This PR adds/removes/updates test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants