Use Function("return this") to get global?

[creatorrr]

Underscore currently breaks in 'strict' mode while trying to access properties on the global object. The global object is being set using the (function(root) { ... })(this) pattern. However, in this case, root remains undefined and hence the issue.

Using the Function("return this")() pattern instead alleviates the issue, though arguably ugly. Thoughts?

Steps to reproduce: Import underscore in a babel-jest test harness. (uses strict mode)

[jridgewell]

Would be better to just create a root object on L12.

  var root = this || {};

[jashkenas]

Underscore doesn't use strict mode.

[jridgewell]

It's not an issue of Underscore using strict mode, but the new ES6 module loaders forcing strict mode.

[jashkenas]

Seriously? Strict mode is enforced now in "real" ES6? Or is this just "polyfill" module loaders being zealous?

[jashkenas]

http://people.mozilla.org/~jorendorff/es6-draft.html#sec-strict-mode-code

Ugh.

Is this going to play nice with _.template?

[jridgewell]

It's not strict mode exactly. The ES6 spec says that this is undefined for module contexts.

[jridgewell]

http://people.mozilla.org/~jorendorff/es6-draft.html#sec-strict-mode-code

I stand corrected, it's always strict mode.

[megawac]

Can we replace this with self? I'm pretty sure that should work with all browsers I've ever used

[megawac]

^ That would also add support for loading underscore in webworkers