Upgrade to React 16

[japgolly]

This is going to be non-trivial. Hopefully not a big deal either.

For those salivating and pining in anticipating for this, I hope to get it done this month but no promises (I have a family to support).

Also it will come out in v1.2.0. Before then there'll be a minor release still on React 15.

Edit: Not committing to a timeline but these are the changes:

Changes & Progress

• New render return types
  • arrays
  • strings
  • numbers
  • portals
  • null (how does sjr handle this? should we bother supporting it anyway?) -- don't support; THIS. IS. SCAALAAA!
  • EmptyVdom (Scala version of above)
  • boolean (to support JS syntax bool && expr - should we support this? it's ≈ null, even when true) -- don't support; THIS. IS. SCAALAAA!
  • Option[_] (Scala version of above)
  • fragments
• Fragments
• Portals
  • ReactDOM.createPortal
  • React.Children support for portals (React.Children support for portals react/react#11373)
• "Error boundaries"
  • componentDidCatch
• React Addons have been discontinued
  • react-addons-test-utils is now react-dom/test-utils
  • perf doesn't work with 16 - no replacement yet
  • react-addons-css-transition-group is now react-transition-group, a separate lib
• Deprecated now removed
  • createClass
• VDOM
  • Allow on as a custom attribute for AMP. Allow custom attribute named on to be passed on to elements react/react#11153
  • Remove VdomElement? -- Nope, still needed by ReactDOM
• Other
  • New rules for Keys
  • New rules for Refs
  • getDOMNode should now return Element | Text instead of just Element
  • Refresh vdom builder prod-mode logic
  • Refresh component builder logic
  • componentDidUpdate lifecycle no longer receives prevContext param. See Pass prevContext param to componentDidUpdate react/react#8631 (Don't think sjr is affected)
  • Remember to test module paths with sjs-bundler -- wasted enough time trying to get fragile bundler to even run my tests
  • Depends on requestAnimationFrame (even in test environments). Might need shim: import 'raf/polyfill'

Externalised

• Support new setState shapes #448 - Calling setState with null no longer triggers an update.
• Update doc for React 16 #449 - Update docs

[japgolly]

https://twitter.com/japgolly/status/933118294705422336

Would anyone be interested in sponsoring me to update #scalajs-#react to React 16?

Context: I've never been paid any of my time on OSS; all of my OSS work I've done at the cost of other paying work. React16 is non-trivial and I doubt I'll be able to do it for free for a while.

I envision 3 outcomes here.

1. I get sponsored and add React 16 support.
2. Community member(s) contribute React 16 support (understanding that the review process might be a little slow).
3. We all wait until next year and likely Q2/Q3 at that.

[japgolly]

And to those of you reading this because you've subscribed because you love the project, you're probably disappointed and I'm sorry for that. It will definitely happen, externally, it's just a matter of when.

[bjenkinsgit]

How can we contribute (financially) ?

…

On Nov 21, 2017, at 6:53 PM, David Barri ***@***.***> wrote: https://twitter.com/japgolly/status/933118294705422336 <https://twitter.com/japgolly/status/933118294705422336> Would anyone be interested in sponsoring me to update #scalajs-#react to React 16? Context: I've never been paid any of my time on OSS; all of my OSS work I've done at the cost of other paying work. React16 is non-trivial and I doubt I'll be able to do it for free for a while. I envision 3 outcomes here. I get sponsored and add React 16 support. Community member(s) contribute React 16 support (understanding that the review process might be a little slow). We all wait until next year and likely Q2/Q3 at that. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#418 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIIsQScTaJ35_nJ0s_sB1dIh206pr7e3ks5s42JdgaJpZM4P0yL4>.

[ngbinh]

as mentioned in Twitter, I would love to contribute to making this happen. Thanks for the awesome work!

[erinmez]

@japgolly I would like to donate too. Is this set up somewhere already?

[japgolly]

Hi all. I've setup a patreon page. If you would like to contribute and are able, I'd really appreciate your support. If you know any one else that enjoys this project, my other OSS libraries, or even my programming blog enough to support me and could reach out to them, that would be tremendously helpful too. Thank you! 🙇‍♂️

[nafg]

BTW I'm using the existing version on 16, so I guess this is about adding new features like essentially returning VdomArray instead of VdomElement? Or am I missing a lot?

[japgolly]

@nafg yes, exactly. I need to go through all the React 16.x changelogs and find anything and everything that requires a change here. So adding new features like the portal stuff, adding new VDOM, updating the type-system for new logic/rules (like returning VdomArray from render), etc.

But because React 16 is backwards-compatible with React 15, so too will scalajs-react work with React 16 in a React 15 way.

[nafg]

Thanks for the explanation :)

[japgolly]

no worries :)

…

On 17 December 2017 at 17:48, nafg ***@***.***> wrote: Thanks for the explanation :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#418 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMYt-PIvML1v6T4jtJPyG3ffR-2kNQsks5tBLlagaJpZM4P0yL4> .

[japgolly]

Ok these are the changes required for full React 16 support:

• New render return types
  • arrays
  • strings
  • numbers
  • portals
  • null (how does sjr handle this? should we bother supporting it anyway?)
  • EmptyVdom (Scala version of above)
  • boolean (to support JS syntax bool && expr - should we support this? it's ≈ null, even when true)
  • Option[_] (Scala version of above)
  • fragments
• Fragments
• Portals
  • ReactDOM.createPortal
  • React.Children support for portals (React.Children support for portals react/react#11373)
• "Error boundaries"
  • componentDidCatch
• React Addons have been discontinued
  • react-addons-test-utils is now react-dom/test-utils
  • perf doesn't work with 16 - no replacement yet
  • react-addons-css-transition-group is now react-transition-group, a separate lib
• Deprecated now removed
  • createClass
• VDOM
  • Allow on as a custom attribute for AMP. #11153
• Other
  • Calling setState with null no longer triggers an update.
    • Support S => Option[S]-like patterns, setState filters
  • componentDidUpdate lifecycle no longer receives prevContext param. See #8631 (Don't think sjr is affected)
  • Remember to test module paths with sjs-bundler
  • Depends on requestAnimationFrame (even in test environments). Might need shim: import 'raf/polyfill'
  • ReactDOMServer.renderToNodeStream() and ReactDOMServer.renderToStaticNodeStream()