Skip to content

Closing slash behavior doesn't match documentation #1583

Description

@sjoqvist

Current behaviour 💣

The plugin minifies the production code while keeping closing slashes, which is different from the default behavior of html-minifier-terser.

Expected behaviour ☀️

The closing slashes should be removed according to the documentation. While the documentation doesn't specifically mention keepClosingSlash, it mentions other minification overrides which makes the reader believe that this one is unaltered.

This is likely introduced by #1371, which modified the code without modifying the documentation. While I think that the current behavior is reasonable, it took some debugging to understand why it didn't match my expectations. Hence, perhaps the documentation should be updated?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions