fix: use quorum queue - #1183
Merged
ivis-miyachi merged 3 commits intoJul 30, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Not ready to approve
It includes a malformed triple-quoted comment string and a potentially unresolvable Celery pin (celery==5.5) that should be corrected for build reliability.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Updates WEKO’s Celery/RabbitMQ configuration and Python dependency pins to support Celery 5.5 and enforce RabbitMQ quorum queues for the default Celery queue.
Changes:
- Configure Celery’s default queue as a RabbitMQ quorum queue in
scripts/instance.cfg. - Upgrade Celery/Billiard versions and update Kombu/Invenio-Celery sources in requirements files.
- Add
tzdatato the Python package set.
File summaries
| File | Description |
|---|---|
| scripts/instance.cfg | Adds Celery queue/exchange configuration for quorum queues and broker transport options. |
| packages.txt | Updates Celery/Billiard, adjusts Kombu source, and adds tzdata. |
| packages-invenio.txt | Switches invenio-celery from a pinned release to a Git-based editable install. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 4
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| ), | ||
| ) | ||
| BROKER_TRANSPORT_OPTIONS = {"confirm_publish": True} | ||
| """" celery settings for quorum queues """ |
| jsonpath-ng == 1.5.2 | ||
| #kombu==5.3.7 | ||
| -e git+https://github.com/RCOSDP/kombu.git@nii_develop/W2024-16#egg=kombu | ||
| -e git+https://github.com/RCOSDP/kombu.git@nii_develop/W2026-31#egg=kombu |
| invenio-base==1.4.0 | ||
| invenio-cache==1.3.0 | ||
| invenio-celery==1.3.1 | ||
| -e git+https://github.com/RCOSDP/invenio-celery.git@nii_develop/W2026-31#egg=invenio-celery |
| captcha==0.6.0 | ||
| cchardet==2.2.0a2 | ||
| celery==5.3.6 | ||
| celery==5.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for using quorum queue and celery5.5