envoy file provider support omit_empty_values#3426
Conversation
istio-testing
added
the
size/XS
zirain
added
the
release-notes-none
|
/test release-notes |
zirain
changed the title
omit_empty_values
| // Optional. If set to true, when command operators are evaluated to null, | ||
| // For text format, the output of the empty operator is changed from “-“ to an empty string. | ||
| // For json format, the keys with null values are omitted in the output structure. | ||
| bool omit_empty_values = 3; |
There was a problem hiding this comment.
by default is it is empty, isn't it difficult to distinguish which field is empty?
There was a problem hiding this comment.
for text, yes.
but it's useful for json.
There was a problem hiding this comment.
So can we only make it work for json
There was a problem hiding this comment.
I think it's fine to give user the option, instead of make an exception.
User can use customized separator, e.g. [%CEL(xxxxxx)%].
istio-testing
added
the
needs-rebase
a307350 to
600974e
Compare
istio-testing
removed
the
needs-rebase
|
kindly ping @istio/technical-oversight-committee |
keithmattix
left a comment
keithmattix
left a comment
There was a problem hiding this comment.
A couple of things:
1: I'm not totally sure what the use case is even after reading the linked issue.
2. Why MeshConfig over Telemetry API?
Before, envoy will send
|
4 participants
xref: istio/istio#54930