Skip to content

Add Catalan translation#966

Merged
ix5 merged 2 commits intoisso-comments:masterfrom
welpo:feat/catalan-localisation
Aug 21, 2023
Merged

Add Catalan translation#966
ix5 merged 2 commits intoisso-comments:masterfrom
welpo:feat/catalan-localisation

Conversation

@welpo
Copy link
Copy Markdown
Contributor

@welpo welpo commented Aug 17, 2023

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

Adds Catalan translation.

Why is this necessary?

Over 9 million people speak Catalan :)

@welpo
Copy link
Copy Markdown
Contributor Author

welpo commented Aug 17, 2023

I'm not sure about adding an entry to CHANGES.rst. Should I add a "New features" section inside "TBD" like this?

- TBD

New Features
^^^^^^^^^^^^

- Add Catalan localisation (`#966`_, welpo)

Bugfixes & Improvements
^^^^^^^^^^^^^^^^^^^^^^^

- Python 3.11 support (`#832`_, l33tname)
…

@welpo welpo changed the title app: i8n: Add Catalan translation Add Catalan translation Aug 17, 2023
@ix5
Copy link
Copy Markdown
Member

ix5 commented Aug 17, 2023

Please squash the two commits into one, otherwise LGTM.

Thank you for your contribution!

@welpo
Copy link
Copy Markdown
Contributor Author

welpo commented Aug 17, 2023

Done!

Should I update the CHANGES.rst file as mentioned above?

@ix5
Copy link
Copy Markdown
Member

ix5 commented Aug 17, 2023

Done!

Should I update the CHANGES.rst file as mentioned above?

Yes, please.

@welpo
Copy link
Copy Markdown
Contributor Author

welpo commented Aug 17, 2023

Done!

@ix5 ix5 merged commit 1871a93 into isso-comments:master Aug 21, 2023
@ix5
Copy link
Copy Markdown
Member

ix5 commented Aug 21, 2023

Great, thank you! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants