__init__.py: Fix config startup check#811
Merged
ix5 merged 2 commits intoisso-comments:masterfrom Mar 20, 2022
Merged
Conversation
be821b4 to
44535e1
Compare
Contributor
Author
|
I hope there is a better solution than this |
Member
|
Hmm, I have not run into any issues with Please note that from a first glance, your change looks very sensible. |
Contributor
Author
|
Good point i will add a way to reproduces this issue. I ran into that when testing the last pre-release. |
Contributor
Author
|
Here is the example: on master branch on this branch |
gunicorn is not using main() it uses make_app via run.py. Because of that we should check for the config file inside make_app. This is probably also true for other deployment options.
Member
|
Looks like a sensible change. Thanks! |
44535e1 to
c57ee6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gunicorn is not using main() it uses make_app via run.py.
Because of that we should check for the config file inside
make_app.
This is probably also true for other deployment options.