fix(openapi): keep request body with empty-schema fallback - #6
Merged
Conversation
When `options.body` is declared but the schema library doesn't expose `~standard.jsonSchema`, `getRequestBody` returned undefined and dropped the request body, documenting a body-consuming route as bodyless. Fall back to an empty schema (accepts any JSON) so the requestBody is always emitted; only the schema shape degrades. Adds a regression test with a converter-less schema. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the new Greptile P1 on better-auth#153 ("Body Schemas Disappear"): when an endpoint declares a
bodybut the schema library doesn't expose~standard.jsonSchema,getRequestBodyreturnedundefined, so a body-consuming route was documented as bodyless and generated clients could omit JSON the runtime expects. This falls back to an empty schema (toJsonSchema(...) ?? {}, which accepts any JSON) so a declared body is always documented; only the schema shape degrades. Adds a regression test using a converter-less Standard Schema. All 202 tests and thetsdownbuild pass.🤖 Generated with Claude Code