fix: return error instead of log.Fatal in HolePunching - #11365
Merged
Conversation
Signed-off-by: reflecttypefor <reflecttypefor@outlook.com>
The Changelog section is generated at release time, so hand-written notes belong under Highlights instead.
lidel
approved these changes
Jun 21, 2026
lidel
left a comment
lidel
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Added test to lock this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HolePunching function in core/node/libp2p/relay.go calls log.Fatal when Swarm.EnableHolePunching is explicitly enabled but Swarm.RelayClient.Enabled is not true. log.Fatal immediately terminates the process with os.Exit(1), which bypasses normal shutdown hooks and prevents the fx framework from handling the failure gracefully. The function already has a named err return value, so returning an error is the correct Go idiom.
Replace log.Fatal(...) with err = fmt.Errorf(...) so the error propagates through fx's provider chain. This gives users a descriptive startup error message instead of an abrupt process termination. No behavioral change for the default case (where Swarm.EnableHolePunching is not explicitly set) — hole punching is still silently disabled when relay client is off.