Skip to content

test: correct type in scalarConfig - #27

Merged
inyourtime merged 2 commits into
mainfrom
fix-type-test
Apr 13, 2026
Merged

test: correct type in scalarConfig#27
inyourtime merged 2 commits into
mainfrom
fix-type-test

Conversation

@inyourtime

@inyourtime inyourtime commented Apr 13, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Tests
    • Updated test configuration callbacks to read request parameters from the correct data source.

@coderabbitai

coderabbitai Bot commented Apr 13, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@inyourtime has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 23 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 55 minutes and 23 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4954a126-ccda-4999-954f-86035756cc60

📥 Commits

Reviewing files that changed from the base of the PR and between 94134c3 and c29dd15.

📒 Files selected for processing (1)
  • test-types/index.tst.ts
📝 Walkthrough

Walkthrough

The scalarConfig callback logic in the test file has been updated to read the customUrl parameter from request.params instead of request.query. This change applies to both the synchronous and asynchronous callback implementations.

Changes

Cohort / File(s) Summary
Test Configuration Update
test-types/index.tst.ts
Updated scalarConfig callbacks to retrieve customUrl from request.params instead of request.query in both sync and async cases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop through the params, not the query so deep,
Where the config now finds what it needs to keep,
From request.params the path is now clear,
Both sync and async now gather data here! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'test: correct type in scalarConfig' is vague and does not clearly describe the actual change made (updating data source from request.query to request.params). Consider a more descriptive title such as 'test: update scalarConfig to read customUrl from request.params' to clearly convey the specific change being made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-type-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test-types/index.tst.ts`:
- Line 49: The test is reading customUrl from path params but the plugin
supplies it as a query-string; update the arrow function(s) that currently use
request.params.customUrl (e.g., the scalarConfig: (request) => (...) entry and
the other mapping at the second occurrence) to read request.query.customUrl
instead and fall back to '/default.json' when undefined so the test matches
actual `@hapi/hapi` Request usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e31eec86-2c86-4a0c-b3bf-da1da9702d8c

📥 Commits

Reviewing files that changed from the base of the PR and between 6480034 and 94134c3.

📒 Files selected for processing (1)
  • test-types/index.tst.ts

Comment thread test-types/index.tst.ts Outdated
@inyourtime
inyourtime merged commit 313d607 into main Apr 13, 2026
9 checks passed
@inyourtime
inyourtime deleted the fix-type-test branch April 13, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant