Fix progress preview gallery selection - #9217
Merged
lstein merged 3 commits intoJun 6, 2026
Merged
Conversation
JPPhoto
requested review from
Pfannkuchensack,
blessedcoolant,
dunkeroni and
lstein
as code owners
May 20, 2026 13:51
JPPhoto
force-pushed
the
progress-preview-gallery-selection
branch
from
May 22, 2026 03:37
8c4d37b to
198b69b
Compare
JPPhoto
force-pushed
the
progress-preview-gallery-selection
branch
3 times, most recently
from
May 27, 2026 21:23
989e932 to
73385ce
Compare
JPPhoto
force-pushed
the
progress-preview-gallery-selection
branch
from
May 29, 2026 11:03
73385ce to
cb5a4d3
Compare
lstein
approved these changes
Jun 6, 2026
lstein
left a comment
lstein
left a comment
Collaborator
There was a problem hiding this comment.
Works as advertised. Code check clean.
lstein
enabled auto-merge (squash)
June 6, 2026 20:59
lstein
disabled auto-merge
June 6, 2026 20:59
The reveal effect's own cleanup already clears selectedImageRevealTimeoutId on unmount; the unmount-only effect just needs to reset the atom. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lstein
enabled auto-merge (squash)
June 6, 2026 21:02
dunkeroni
pushed a commit
to dunkeroni/InvokeAI
that referenced
this pull request
Jun 29, 2026
* Fix progress preview gallery selection * Remove redundant clearTimeout in unmount cleanup effect The reveal effect's own cleanup already clears selectedImageRevealTimeoutId on unmount; the unmount-only effect just needs to reset the atom. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes image viewer progress preview behavior when selecting gallery images during generation. Previously, selecting a gallery image during an active progress preview cleared the preview immediately, leaving the selected image visible until the next progress update or completion.
When a progress preview is visible, selecting a gallery image now shows that selected image for 2 seconds before returning to the active progress preview. The preview continues updating behind that temporary reveal. The Info button now matches the visible state: it is enabled during the 2-second selected-image reveal and disabled again when the progress overlay returns.
Also fixes a race where a stale completion handoff could clear a newer generation's progress preview.
Related Issues / Discussions
QA Instructions
Manual behavior to verify:
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)