No longer clear authorization before returning from getServerSpec - #347
Merged
isc-klu merged 3 commits intoAug 13, 2026
Merged
Conversation
isc-klu
marked this pull request as draft
August 12, 2026 22:13
isc-klu
requested review from
gjsjohnmurray and
isc-bsaviano
and removed request for
isc-bsaviano
August 13, 2026 13:24
isc-klu
marked this pull request as ready for review
August 13, 2026 13:32
isc-klu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #348.
The ServerSpec returned by getServerSpec() in src/commonActivate.ts is constructed by getServerSpec() in src/api/getServerSpec.ts. I verified that every code path in the latter function returns a resolved Authorization object only when:
Because of this, it is safe for getServerSpec() to return the Authorization object without clearing its access token.
This PR removes the access token clearing logic and makes a small refactoring to src/api/getServerSpec.ts to clarify the control flow.