fix(validin): add missing continue statement in _run_all_queries - #3644
Merged
Merged
Conversation
Contributor
Author
|
Greetings @mlodic, This PR fixes #3642 a missing Without the It's a small one-line fix. Happy to make any changes if needed. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3642.
If your PR is made by a single commit, please add that clause in the commit too.
Description
Added a missing
continuestatement in the_run_all_queriesmethod of the Validin analyzer.When an API endpoint returned a non-200 status code, the error was logged but execution continued to
response.json(), which would throw aJSONDecodeErrorif the response body was HTML instead of JSON. This broke the entire loop and crashed the analyzer, violating the intended behavior described in the existing comment:# we wont stop other quries from executing if one fails.The fix simply adds
continueafter the error log so the loop skips to the next endpoint gracefully.Type of change
Checklist
develop