Skip to content

fix(validin): add missing continue statement in _run_all_queries - #3644

Merged
mlodic merged 1 commit into
intelowlproject:developfrom
Abhishek9639:fix/3642
Apr 9, 2026
Merged

mlodic merged 1 commit into
intelowlproject:developfrom
Abhishek9639:fix/3642

Conversation

@Abhishek9639

Copy link
Copy Markdown
Contributor

Closes #3642.
If your PR is made by a single commit, please add that clause in the commit too.

Description

Added a missing continue statement in the _run_all_queries method of the Validin analyzer.

When an API endpoint returned a non-200 status code, the error was logged but execution continued to response.json(), which would throw a JSONDecodeError if the response body was HTML instead of JSON. This broke the entire loop and crashed the analyzer, violating the intended behavior described in the existing comment: # we wont stop other quries from executing if one fails.

The fix simply adds continue after the error log so the loop skips to the next endpoint gracefully.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop

@Abhishek9639

Copy link
Copy Markdown
Contributor Author

Greetings @mlodic,

This PR fixes #3642 a missing continue statement in the _run_all_queries method of the Validin analyzer.

Without the continue, when an endpoint returns a non-200 response, the code falls through to response.json() which crashes with a JSONDecodeError if the response body is HTML. This breaks the entire loop even though the existing comment says otherwise.

It's a small one-line fix. Happy to make any changes if needed.

Thanks

@mlodic
mlodic merged commit ed743d7 into intelowlproject:develop Apr 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants